Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ADTypes.jl v1.0 #16

Merged
merged 8 commits into from
Apr 21, 2024
Merged

Switch to ADTypes.jl v1.0 #16

merged 8 commits into from
Apr 21, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Apr 16, 2024

  • Define TracerSparsityDetector following the AbstractSparsityDetector framework of ADTypes v1.0
  • Remove SparseDiffTools extension
  • Add tests
  • Add docs
  • Commit manifests and tweak docs CI because ADTypes v1.0 is not released
  • Put test extras in the main project file to avoid "cannot merge projects" error JuliaLang/Pkg.jl#1585

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (f6350a9) to head (e2513c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   81.17%   80.24%   -0.93%     
==========================================
  Files           6        6              
  Lines          85       81       -4     
==========================================
- Hits           69       65       -4     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill
Copy link
Owner

adrhill commented Apr 17, 2024

Do you need this now?
I'd like to wait a little bit longer and add proper Jacobian and Hessian tracer types.
And ADTypes v1.0 isn't registered yet.

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 17, 2024

As you wish, no rush

@adrhill adrhill merged commit 3830ca0 into adrhill:main Apr 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants