Refine tests

- fix Runtime policy
- update to JUnit5

build.gradle

@@ -25,7 +25,12 @@ allprojects {
   }
 
   dependencies {
-    testImplementation 'junit:junit:4.13.2'
+    testImplementation 'org.junit.jupiter:junit-jupiter:5.11.0'
+    testImplementation 'org.junit.platform:junit-platform-launcher:1.10.3'
+  }
+
+  test {
+    useJUnitPlatform()
   }
 }
 

io.github.adr.embedded/src/main/java/io/github/adr/embedded/ArchitecturallySignificant.java

@@ -21,7 +21,7 @@
     ElementType.TYPE_PARAMETER,
     ElementType.TYPE_USE})
 @ADR(2)
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 public @interface ArchitecturallySignificant {
 

io.github.adr.embedded/src/main/java/io/github/adr/embedded/MADR.java

@@ -22,7 +22,7 @@
     ElementType.TYPE_PARAMETER,
     ElementType.TYPE_USE})
 @ADR(2)
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 @Repeatable(MADRs.class)
 public @interface MADR {

io.github.adr.embedded/src/main/java/io/github/adr/embedded/MADRs.java

@@ -20,7 +20,7 @@
     ElementType.TYPE,
     ElementType.TYPE_PARAMETER,
     ElementType.TYPE_USE})
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 public @interface MADRs {
     MADR[] value();

io.github.adr.embedded/src/main/java/io/github/adr/embedded/YStatementJustification.java

@@ -29,7 +29,7 @@
     ElementType.TYPE_PARAMETER,
     ElementType.TYPE_USE})
 @ADR(2)
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 @Repeatable(YStatementJustifications.class)
 public @interface YStatementJustification {

io.github.adr.embedded/src/main/java/io/github/adr/embedded/YStatementJustifications.java

@@ -20,7 +20,7 @@
     ElementType.TYPE,
     ElementType.TYPE_PARAMETER,
     ElementType.TYPE_USE})
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 public @interface YStatementJustifications {
 

io.github.adr.embedded/src/main/java/io/github/adr/linked/ADR.java

@@ -6,7 +6,7 @@
 import java.lang.annotation.RetentionPolicy;
 
 @ADR(2)
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 @Repeatable(ADRs.class)
 public @interface ADR {

io.github.adr.embedded/src/main/java/io/github/adr/linked/ADRs.java

@@ -7,7 +7,7 @@
 /**
  * Required for <code>@Repeatable</code> at {@link ADR}.
  */
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.RUNTIME)
 @Documented
 public @interface ADRs {
     ADR[] value();

io.github.adr.embedded.demo/src/main/java/io/github/adr/embedded/demo/AnnotatedElements.java → io.github.adr.embedded/src/test/java/io/github/adr/embedded/AnnotatedElements.java

@@ -9,7 +9,7 @@
  * Contributors:
  *   Oliver Kopp, Olaf Zimmermann - initial API and implementation
  */
-package io.github.adr.embedded.demo;
+package io.github.adr.embedded;
 
 import java.util.UUID;
 
@@ -18,6 +18,8 @@
 /**
  * Annotations can, by design, not put everywhere.
  * See https://stackoverflow.com/a/8425778/873282
+ *
+ * This class is in test, because it tests if it compiles.
  */
 @ADR(1)
 public class AnnotatedElements {

io.github.adr.embedded/src/test/java/io/github/adr/embedded/ArchitecturallySignificantDemoClass.java

@@ -0,0 +1,10 @@
+package io.github.adr.embedded;
+
+@ArchitecturallySignificant(concerns = "performance and scalability needs", nfrs = {
+    ArchitecturallySignificant.QualityAttribute.PERFORMANCE,
+    ArchitecturallySignificant.QualityAttribute.MANAGEABILITY})
+public class ArchitecturallySignificantDemoClass {
+    public int sampleBusinessLogic(String input) {
+        return 42;
+    }
+}

io.github.adr.embedded/src/test/java/io/github/adr/embedded/ArchitecturallySignificantTest.java

@@ -0,0 +1,28 @@
+package io.github.adr.embedded;
+
+import java.util.Arrays;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class ArchitecturallySignificantTest {
+
+    @Test
+    void annotationPresent() {
+        Class<ArchitecturallySignificantDemoClass> obj = ArchitecturallySignificantDemoClass.class;
+        assertTrue(obj.isAnnotationPresent(ArchitecturallySignificant.class));
+    }
+
+    @Test
+    void annotationContentsCorrect() {
+        Class<ArchitecturallySignificantDemoClass> obj = ArchitecturallySignificantDemoClass.class;
+        ArchitecturallySignificant akmadAnnotation = obj.getAnnotation(ArchitecturallySignificant.class);
+        assertEquals("performance and scalability needs", akmadAnnotation.concerns());
+        assertEquals(Arrays.asList(
+                ArchitecturallySignificant.QualityAttribute.PERFORMANCE,
+                ArchitecturallySignificant.QualityAttribute.MANAGEABILITY),
+            Arrays.asList(akmadAnnotation.nfrs()));
+    }
+}

io.github.adr.embedded/src/test/java/io/github/adr/embedded/MADRAnnotationPojoDemoClass.java

@@ -0,0 +1,15 @@
+package io.github.adr.embedded;
+
+@MADR(value = 1,
+    title = "Implement entire business logic layer as POJO",
+    contextAndProblem = "Need to select a single consistent ComponentImplementationParadigm' for entire business logic layer",
+    alternatives = {"POJO", "JEE EJB", "Spring Bean"},
+    chosenAlternative = "POJO",
+    justification = "Because it is a company-wide policy.",
+    relatedDecisions = {2, 3})
+public class MADRAnnotationPojoDemoClass {
+    public int sampleBusinessLogic(String input) {
+        return 42;
+    }
+
+}

io.github.adr.embedded/src/test/java/io/github/adr/embedded/MADRTest.java

@@ -0,0 +1,30 @@
+package io.github.adr.embedded;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class MADRTest {
+
+    @Test
+    void annotationPresent() {
+        Class<MADRAnnotationPojoDemoClass> obj = MADRAnnotationPojoDemoClass.class;
+        assertTrue(obj.isAnnotationPresent(MADR.class));
+    }
+
+    @Test
+    void annotationContentsCorrect() {
+        Class<MADRAnnotationPojoDemoClass> obj = MADRAnnotationPojoDemoClass.class;
+        MADR madr = obj.getAnnotation(MADR.class);
+
+        assertEquals(1, madr.value());
+        assertEquals("Implement entire business logic layer as POJO", madr.title());
+        assertEquals("Need to select a single consistent ComponentImplementationParadigm' for entire business logic layer", madr.contextAndProblem());
+        assertArrayEquals(new String[]{"POJO", "JEE EJB", "Spring Bean"}, madr.alternatives());
+        assertEquals("POJO", madr.chosenAlternative());
+        assertEquals("Because it is a company-wide policy.", madr.justification());
+        assertArrayEquals(new int[]{2, 3}, madr.relatedDecisions());
+    }
+}