Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add the step to install our library in readme #6

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ArmandMeppa
Copy link
Collaborator

No description provided.

@ArmandMeppa ArmandMeppa added the documentation Improvements or additions to documentation label May 16, 2024
@ArmandMeppa ArmandMeppa requested a review from Marcjazz May 16, 2024 11:05
@ArmandMeppa ArmandMeppa self-assigned this May 16, 2024
Copy link
Collaborator

@Marcjazz Marcjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve this PR once the source code on the main branch has completely integrated the de.adorsys domain

Copy link
Collaborator

@Marcjazz Marcjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried importing it without success

<dependency>
<groupId>de.adorsys</groupId>
<artifactId>sd-jwt</artifactId>
<version>1.0-SNAPSHOT</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the SNAPSHOT required ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add a placeholder encouraging consumers to look for for the latest version on Maven.

@IngridPuppet IngridPuppet changed the base branch from main to develop July 30, 2024 14:03
@IngridPuppet
Copy link
Collaborator

@ArmandMeppa Please attend this PR, and let us have it closed. We'll need another release with a bug fix on Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants