Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(configuration): setting up workspace #89

Merged
merged 4 commits into from
Jun 26, 2024
Merged

feat(configuration): setting up workspace #89

merged 4 commits into from
Jun 26, 2024

Conversation

Christiantyemele
Copy link
Collaborator

No description provided.

@Christiantyemele Christiantyemele linked an issue Jun 26, 2024 that may be closed by this pull request
Add Workspace Cargo.toml File to the Project #86
Closed
@Christiantyemele Christiantyemele self-assigned this Jun 26, 2024
Hermann-Core
Hermann-Core reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@Hermann-Core Hermann-Core left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resolver = "2" parameter is missing from the [workspace] section. Since Rust 1.51.0, Cargo has opt-in support for a new feature resolver that will be the default resolver for the new Rust editions starting with edition 2021. It needs to be enabled in the entire workspace. You can do that by either adding resolver = "2" parameter or edition = "2021" in the workspace parameter which will automatically infer resolver = "2". Could you please update your pull request to include one of these changes?

@Christiantyemele
Copy link
Collaborator Author

The resolver = "2" parameter is missing from the [workspace] section. Since Rust 1.51.0, Cargo has opt-in support for a new feature resolver that will be the default resolver for the new Rust editions starting with edition 2021. It needs to be enabled in the entire workspace. You can do that by either adding resolver = "2" parameter or edition = "2021" in the workspace parameter which will automatically infer resolver = "2". Could you please update your pull request to include one of these changes?

Understood 👍

@Hermann-Core Hermann-Core merged commit 80395b7 into main Jun 26, 2024
1 check passed
@Hermann-Core Hermann-Core deleted the iss86-workspace branch June 26, 2024 12:02
@Hermann-Core Hermann-Core mentioned this pull request Jun 26, 2024
Merged
@Hermann-Core
Copy link
Collaborator

Hermann-Core commented Jun 26, 2024 •
edited
Loading

@Christiantyemele why have you deleted the .gitignore file? please submit a new pull request without removing that file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis-pouatcha francis-pouatcha Awaiting requested review from francis-pouatcha

@Hermann-Core Hermann-Core Awaiting requested review from Hermann-Core

Assignees

@Christiantyemele Christiantyemele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Workspace Cargo.toml File to the Project
2 participants
@Christiantyemele @Hermann-Core