Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Did rotation handler #190

Merged
merged 29 commits into from
Nov 4, 2024
Merged

Did rotation handler #190

merged 29 commits into from
Nov 4, 2024
+417 −13

Conversation

Christiantyemele
Copy link
Collaborator

No description provided.

@Christiantyemele
Copy link
Collaborator Author

Christiantyemele commented Sep 27, 2024 •
edited
Loading

Hey @Blindspot22 @Hermann-Core , @IngridPuppet my testss is failling for some reason which i do not suspect any help will be welcomed

@Christiantyemele Christiantyemele linked an issue Sep 27, 2024 that may be closed by this pull request
implement did rotation check and handler #181
Closed
@Blindspot22
Copy link
Collaborator

Blindspot22 commented Sep 27, 2024 •
edited
Loading

I think one of the error you're encountering is related to the failed test test_did_rotation in the mediator-coordination module.

The test test_did_rotation is failing because the function you're testing is attempting to use a signature algorithm that is not supported. I think you are trying to unwrap a Result, but the Result contains an Err instead of an Ok.

Screenshot from 2024-09-27 12-42-28

Check line 206 in the rotation.rs file

@Christiantyemele Christiantyemele self-assigned this Oct 1, 2024
@Christiantyemele Christiantyemele mentioned this pull request Sep 25, 2024
Closed
Blindspot22
Blindspot22 requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@Blindspot22 Blindspot22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-10-17 16-02-48
Are you aware this branch has Conflicts? @Christiantyemele

@Christiantyemele
Copy link
Collaborator Author

Screenshot from 2024-10-17 16-02-48 Are you aware this branch has Conflicts? @Christiantyemele

for now its normal we have conflicts , they are some changes in the main branch, all i want is the logic and functionality to be checked

IngridPuppet
IngridPuppet requested changes Oct 17, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/didcomm/bridge.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/errors.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/errors.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/lib.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/rotation.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/rotation.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/rotation.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/rotation.rs Outdated Show resolved Hide resolved
crates/plugins/mediator-coordination/src/rotation/rotation.rs Outdated Show resolved Hide resolved
@chendiblessing chendiblessing marked this pull request as draft October 31, 2024 15:03
@Christiantyemele Christiantyemele marked this pull request as ready for review November 4, 2024 07:32
@Blindspot22
Copy link
Collaborator

Blindspot22 commented Nov 4, 2024 •
edited
Loading

Where is the change of the typo?

@Blindspot22
Copy link
Collaborator

LGTM 🚀

@Christiantyemele Christiantyemele merged commit 9765dfd into main Nov 4, 2024
2 checks passed
@Christiantyemele Christiantyemele deleted the did-rotation-handler branch November 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blindspot22 Blindspot22 Blindspot22 approved these changes

@IngridPuppet IngridPuppet IngridPuppet approved these changes

@Hermann-Core Hermann-Core Awaiting requested review from Hermann-Core

Assignees

@Christiantyemele Christiantyemele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement did rotation check and handler
4 participants
@Christiantyemele @Blindspot22 @IngridPuppet @Hermann-Core