Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

343 modify checkstyle to remove unnecessary checks and stop console output by checkstyle #345

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

forkimenjeckayang
Copy link
Collaborator

No description provided.

@forkimenjeckayang forkimenjeckayang linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Aug 6, 2024

@forkimenjeckayang forkimenjeckayang changed the title 343 modify checkstyle to remove unnecessary checks and stop console output checkstyle 343 modify checkstyle to remove unnecessary checks and stop console output by checkstyle Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 82.99320% with 25 lines in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (283ea2a) to head (fe2e4d2).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ng/factory/SpringSimpleDatasafeServiceFactory.java 60.00% 0 Missing and 4 partials ⚠️
...ry/impl/profile/keys/DFSPrivateKeyServiceImpl.java 0.00% 0 Missing and 3 partials ⚠️
...rsys/datasafe/rest/impl/config/DatasafeConfig.java 81.25% 3 Missing ⚠️
...safe/storage/impl/fs/FileSystemStorageService.java 50.00% 0 Missing and 3 partials ⚠️
...ys/datasafe/rest/impl/DatasafeRestApplication.java 0.00% 2 Missing ⚠️
...simple/adapter/impl/SimpleDatasafeServiceImpl.java 94.44% 0 Missing and 2 partials ⚠️
...dorsys/datasafe/types/api/actions/ReadRequest.java 33.33% 2 Missing ⚠️
...rsys/datasafe/types/api/actions/RemoveRequest.java 33.33% 2 Missing ⚠️
...de/adorsys/datasafe/types/api/utils/Obfuscate.java 33.33% 0 Missing and 2 partials ⚠️
...safe/runtimedelegate/RuntimeDelegateGenerator.java 95.45% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #345      +/-   ##
=============================================
+ Coverage      86.76%   86.79%   +0.02%     
  Complexity         1        1              
=============================================
  Files            164      164              
  Lines           3348     3354       +6     
  Branches         217      217              
=============================================
+ Hits            2905     2911       +6     
  Misses           309      309              
  Partials         134      134              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

checkstyle.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
checkstyle.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 30, 2024

@francis-pouatcha francis-pouatcha merged commit f195bcd into develop Oct 1, 2024
3 of 4 checks passed
@francis-pouatcha francis-pouatcha deleted the 343-modify-checkstyle branch October 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Checkstyle
4 participants