-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect jdkbinary JDK folder directory when run from Rebuild_Same_JDK_Reproducibility_Test #4032
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approving yet as the Grinder doesn't look to have been successful:
17:16:08 Number of differences: 432
17:16:08 ./repro_compare.sh: line 77: (files1-num_differences)*100*100/files1 : division by 0 (error token is "files1 ")
17:16:08 ReproduciblePercent = 0. %
17:16:08 Differences found..., logged in: reprotest.diff
17:16:29 -----------------------------------
17:16:29 Rebuild_Same_JDK_Reproducibility_Test_0_FAILED
17:16:29 -----------------------------------
mmm something else not right! |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
so I was wrong! I misstook the jdk-21.0.6+2 folder for what I thought was the JDK, it was in fact a different archive(debug image artifact), along side also the static-libs folder which is getting placed in j2sdk-image, ref: https://adoptium.slack.com/archives/C09NW3L2J/p1731420319899309?thread_ts=1731417632.215039&cid=C09NW3L2J |
Will be fixed by adoptium/aqa-tests#5749 |
When linux_repro_build_compare.sh was called from aqa-tests passing the jdkbinary folder it was comparing the top-level jdkbinary folder containing all the artifacts (jdk,jre,static-libs,..) rather than the jdk-VERSION folder...
Slightly complicated by the fact that TKG calls using the expanded "all artifacts" top directory (jdkbinary), whereas a "user" might expect to call using a local reference to the jdk-V.0.M+B folder. I've updated the script to assume the when
a local directory is used it references the folder that contains the jdk-V.0.M+B folder specified in the SBOM.
Grinder test: https://ci.adoptium.net/job/Grinder/11309/