Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect jdkbinary JDK folder directory when run from Rebuild_Same_JDK_Reproducibility_Test #4032

Closed
wants to merge 10 commits into from

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Nov 11, 2024

When linux_repro_build_compare.sh was called from aqa-tests passing the jdkbinary folder it was comparing the top-level jdkbinary folder containing all the artifacts (jdk,jre,static-libs,..) rather than the jdk-VERSION folder...

Slightly complicated by the fact that TKG calls using the expanded "all artifacts" top directory (jdkbinary), whereas a "user" might expect to call using a local reference to the jdk-V.0.M+B folder. I've updated the script to assume the when
a local directory is used it references the folder that contains the jdk-V.0.M+B folder specified in the SBOM.

Grinder test: https://ci.adoptium.net/job/Grinder/11309/

@andrew-m-leonard andrew-m-leonard self-assigned this Nov 11, 2024
@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label Nov 11, 2024
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving yet as the Grinder doesn't look to have been successful:

17:16:08  Number of differences: 432
17:16:08  ./repro_compare.sh: line 77: (files1-num_differences)*100*100/files1 : division by 0 (error token is "files1 ")
17:16:08  ReproduciblePercent = 0. %
17:16:08  Differences found..., logged in: reprotest.diff
17:16:29  -----------------------------------
17:16:29  Rebuild_Same_JDK_Reproducibility_Test_0_FAILED
17:16:29  -----------------------------------

@andrew-m-leonard
Copy link
Contributor Author

mmm something else not right!

@andrew-m-leonard andrew-m-leonard marked this pull request as draft November 11, 2024 21:47
@andrew-m-leonard
Copy link
Contributor Author

so I was wrong! I misstook the jdk-21.0.6+2 folder for what I thought was the JDK, it was in fact a different archive(debug image artifact), along side also the static-libs folder which is getting placed in j2sdk-image, ref: https://adoptium.slack.com/archives/C09NW3L2J/p1731420319899309?thread_ts=1731417632.215039&cid=C09NW3L2J
I'm going to resolve the issue hopefully in https://github.com/adoptium/aqa-tests/blob/master/get.sh#L451
so jdkbinary is correctly and logically populated as intended

@andrew-m-leonard
Copy link
Contributor Author

Will be fixed by adoptium/aqa-tests#5749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues that enhance or fix our test suites
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants