postBuild plugin manager only available in postBuild groovy

[andrew-m-leonard]

pipeline builds broken as postBuild plugin "manager" is only available in postBuild groovy scripts
https://ci.adoptium.net/job/build-scripts/job/openjdk17-pipeline/899/console

hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: manager for class: Builder

I've commented out the build summary annotation for now

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

[sxa]

Just to be clear - this is a partial revert of #923 if I'm reading it right - it would be good to note which functionality will be lost from that original PR when this is merged. I suggest @sophia-guo reviews it too to ensure she is aware.

[andrew-m-leonard]

Just to be clear - this is a partial revert of #923 if I'm reading it right - it would be good to note which functionality will be lost from that original PR when this is merged. I suggest @sophia-guo reviews it too to ensure she is aware.

Correct, it's just the build summary label text that will be missing, instead i've put an "echo" with the same information

[sxa]

Approving so this can go in for tonight's builds - if @sophia-guo has any objections we can address them afterwards, but this is causing a build break.

[sophia-guo]

I will create a PR to fix this. As the echo only shows the message of link in console output instead of a hyperlink in pipeline job description.

[sophia-guo]

Should be a simple update manager --> context.manager.

[sophia-guo]

I have tested the update manager --> context.manager. works. I will do the update together with the PR for #926

[andrew-m-leonard]

I have tested the update manager --> context.manager. works. I will do the update together with the PR for #926

@sophia-guo ah good.
Another thing i've noticed from the overnight beta builds, is it's being called for non-release builds which is probably fine as provides a good test of it, but it's failing as non-release publishes need a TIMESTAMP field: https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8236/

[sophia-guo]

@andrew-m-leonard interesting. Ah, switch between https://github.com/adoptium/ci-jenkins-pipelines/pull/923/files and #916, forgot the condition if (release). The release_tool build was called platform first and then after all jdks are done release_tool build was called again (this is the final one and correct one). This failed release_tool build per platform but won't affect the final one. No worries about the publish but confused and also waste build resources. This will also be fixed by #932