Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable docker image for RISC-V on 21, 22, 23 #869

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

luhenry
Copy link
Contributor

@luhenry luhenry commented Dec 22, 2023

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@luhenry
Copy link
Contributor Author

luhenry commented Dec 22, 2023

@luhenry
Copy link
Contributor Author

luhenry commented Dec 22, 2023

@smlambert @sxa @andrew-m-leonard could I please get a review? This is to match what's done for jdk17u, and jdk19u. I've verified it works for jdk22 at https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk22/job/jdk22-evaluation-linux-riscv64-temurin/11/

@karianna
Copy link
Contributor

Note sure if related but groovy tests fail:

Execution failed for task ':test'.

Could not resolve all files for configuration ':testRuntimeClasspath'.
Could not find org.testng:testng:7.2.0.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/org/testng/testng/7.2.0/testng-7.2.0.pom
- https://repo.jenkins-ci.org/releases/org/testng/testng/7.2.0/testng-7.2.0.pom
- https://repo.jenkins-ci.org/public/org/testng/testng/7.2.0/testng-7.2.0.pom
Required by:
project : > org.codehaus.groovy:groovy-all:3.0.4 > org.codehaus.groovy:groovy-testng:3.0.4

@smlambert
Copy link
Contributor

re: #869 (comment) - seen prior to this PR, reported in #866

@luhenry
Copy link
Contributor Author

luhenry commented Dec 27, 2023

@sxa @smlambert does that look good to you?

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sxa sxa merged commit 5901e15 into adoptium:master Dec 28, 2023
6 of 8 checks passed
@sxa
Copy link
Member

sxa commented Dec 28, 2023

I've triggered a regen of the pipeline jobs so they should pick up this new parameter for the next runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants