-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename jdk21 pipeline config to jdk21u #820
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
Hmm do really want to do a rename when we haven't actually shipped jdk21GA so there's always the possibility of a reason (albeit small)? Regardless, we should ensure that nothing gets schedules to run and publish from jdk21u automatically at the moment as the latest nightly/EA really needs to stay pointing at jdk-21+35 for now until we so the release build. |
Also as a point of note; Please do not remove the JDK21 experimental build pipelines as I have some custom books in there that I don't want to lose. |
@sxa We can pause this for the moment, i've disabled the releaseTrigger_21ea job to ensure that: https://ci.adoptium.net/job/build-scripts/job/utils/job/releaseTrigger_21ea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yep my primary concern here was to make sure that we have new jdk21u things generated and retain the existing jdk21 ones (so that branch could still use the old jobs if needed) and that we didn't rename/delete the existing ones |
@sxa so we have the Jenkins release jobs and pipelines, all based off of the v2023.09.01 branch: And they will not get re-generated unless someone does a manual release re-gen for jdk-21.0.1, and hopefully that point in time should be close to Oct 17th.. |
Signed-off-by: Andrew Leonard <[email protected]>
Rename jdk21 pipeline job configuration to jdk21u.