Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For JDK head, use alternate file/release name #719

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 9, 2023

Part of providing a solution to adoptium/temurin-build#3355

This changes the format of the "nightlies" from: yyyy-HH-dd-HH-mm to ea.21+23 which will be reflected in the filename and also in the published tag. Note that ea.21+23 was chosen instead of 21+23.ea as this fits into the existing regex.

This is currently in draft for multiple reasons:

  1. I have not tested the end to end code
  2. We are in the process of splitting out JDK21 from JDK, so headVersion is probably not what we want now
  3. Looking for validation on the formatting of the filenames and releases
  4. Because of the criteria I've used in this PR, perhaps we should be adjusting the schedule to disable nightlies from new tag before implementing this? Or have a different criteria for these (e.g. "not release but tag specified"). For now we could manually trigger, but a variant of https://github.com/adoptium/mirror-scripts/blob/master/triggerReleasePipeline.sh (called by e.g. https://ci.adoptium.net/job/build-scripts/job/utils/job/releaseTrigger_jdk20u/) which just builds any level that hasn't been built previously rather than working on a static level would be ideal.

NOTE: If we had such a trigger another option would be to still run the nightly build/test cycles as-is but run them as "nightly without publish" so as not to pollute the binaries repositories.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@sxa sxa marked this pull request as draft June 9, 2023 09:51
@sxa
Copy link
Member Author

sxa commented Jun 9, 2023

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@sxa
Copy link
Member Author

sxa commented Jun 9, 2023

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

Signed-off-by: Stewart X Addison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants