Update: change weekly pipeline releaseType from "Release" to "Weekly"

[zdtsw]

Ref: #637

After this PR:
change on standard weekly (not evaluation-weekly) will be from release=true to release=false, publish is still the same "true"
So the behavior is set to the same as the evaluation-weekly
weekly will trigger remote TCK , same as when releaseType == Release

I keep the logic of upload artifacts which was planned as input for comparison job
but if we do not set releaseType as release for weekly, then the build result wont be able to do comparison.

This would require adoptium/jenkins-helper#51 to get merged at the same time.

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

[sophia-guo]

Remote triggers are triggered by both weekly and release build with releaseType=Release. So the remote trigger logic will also need to be updated.

[zdtsw]

Remote triggers are triggered by both weekly and release build with releaseType=Release. So the remote trigger logic will also need to be updated.

@andrew-m-leonard is the plan to keep having weekly trigger "remote TCK" as well?
if yes, then we need to update

ci-jenkins-pipelines/pipelines/build/common/openjdk_build_pipeline.groovy

Line 1864 in 94ad798

if (buildConfig.VARIANT == 'temurin' && isRelease) {

to include "Weekly".

[smlambert]

re: #639 (comment), we want to run TCKs weekly.

[zdtsw]

re: #639 (comment), we want to run TCKs weekly.

Will fix that piece. mark as Draft for now

[andrew-m-leonard]

run tests

[andrew-m-leonard]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[zdtsw]

looks strange, two failed job on win64 indicated something like
"17:17:05 checkoutRequiredCodeToBuild succeeded
17:17:09 warning: failed to remove build/windows-x86_64-server-release/hotspot/variant-server/gensrc/adfiles/ad_x86.hpp: Device or resource busy
17:17:09 warning: failed to remove build/windows-x86_64-server-release/hotspot/variant-server/libjvm/objs/BUILD_LIBJVM.pch: Device or resource busy"

[zdtsw]

run test quick 8,17

[andrew-m-leonard]

looks strange, two failed job on win64 indicated something like "17:17:05 checkoutRequiredCodeToBuild succeeded 17:17:09 warning: failed to remove build/windows-x86_64-server-release/hotspot/variant-server/gensrc/adfiles/ad_x86.hpp: Device or resource busy 17:17:09 warning: failed to remove build/windows-x86_64-server-release/hotspot/variant-server/libjvm/objs/BUILD_LIBJVM.pch: Device or resource busy"

That's usually a Windows "locked file" issue..

[andrew-m-leonard]

run test quick 8,17

[andrew-m-leonard]

run test quick 8,17

[andrew-m-leonard]

I think looks good now

[andrew-m-leonard]

run tests quick 8,17

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅