Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable remote trigger if tests are disabled #424

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

sophia-guo
Copy link
Contributor

Close #422

Signed-off-by: Sophia Guo [email protected]

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,18"

//remote trigger job https://ci.eclipse.org/temurin-compliance/job/AQA_Test_Pipeline/
context.echo "Enable tests: ${enableTests}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
context.echo "Enable tests: ${enableTests}"
context.echo "Enable tests: ${enableTests} so we will trigger the remote JCK jobs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karianna ! That's originally added as testing code and forgot to update. Updated!

@sophia-guo
Copy link
Contributor Author

Not sure about the Linter failure.

2022-10-03 20:56:51 [INFO]   Linting [JSCPD] files...
2022-10-03 20:56:51 [INFO]   ----------------------------------------------
2022-10-03 20:56:51 [INFO]   ----------------------------------------------
2022-10-03 20:56:51 [INFO]   ---------------------------
2022-10-03 20:56:51 [INFO]   File:[/github/workspace/pipelines/build/common/build_base_file.groovy]
2022-10-03 20:56:51 [INFO]    - File:[build_base_file.groovy] was linted with [jscpd] successfully
2022-10-03 20:56:51 [INFO]      - Command output:
------
Detection time:: 1ms
------
2022-10-03 20:56:53 [INFO]   ----------------------------------------------
2022-10-03 20:56:53 [INFO]   ----------------------------------------------
2022-10-03 20:56:53 [INFO]   The script has completed
2022-10-03 20:56:53 [INFO]   ----------------------------------------------
2022-10-03 20:56:53 [INFO]   ----------------------------------------------
2022-10-03 20:56:53 [INFO]   ERROR! Failed to call GitHub Status API!
2022-10-03 20:56:53 [INFO]   ERROR:[curl: (22) The requested URL returned error: 403]
2022-10-03 20:56:53 [ERROR]   ERRORS FOUND in GROOVY:[1]

@sophia-guo
Copy link
Contributor Author

Linter failure see #425, not related with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote trigger to Temurin Compliance server should not occur when nightly testing is disabled
3 participants