Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch JDK22+ on AIX to use OpenXL17-compatible labels #1045

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 18, 2024

Switch the pipelines to ensure that the JDK22+ jobs on AIX are only run on the machines that support OpenXL17

@smlambert I'm going to let you have a veto on this - I've added openxl17 for the build machine and sw.os.aix.7_2TL5 for test - the existing label we're using for earlier machines is the same without the TL5 suffix.

FYI @suchismith1993
Ref: adoptium/temurin-build#3822 (comment)
This will allow us to enable further machines as planned in adoptium/infrastructure#3606
Part of adoptium/infrastructure#3208

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew-m-leonard
Copy link
Contributor

@sxa Linter will hopefully pass if you merge in latest "master" change to move to [email protected]

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa sxa merged commit c991a1b into adoptium:master Jun 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants