-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download dependency libs for MBCS_Tests #5643
Conversation
Grinder links: TARGET: testList TESTLIST=MBCS_Tests_property_utf8_0,MBCS_Tests_language_tag_0 special.functional TARGET: testList TESTLIST=MBCS_Tests_datetime_0,MBCS_Tests_datetime_formatter_0 |
@@ -27,13 +27,16 @@ limitations under the License. | |||
<!--Properties for this particular build--> | |||
<property name="src" location="./src" /> | |||
<property name="build" location="./bin" /> | |||
<property name="junit4.jar" location="${LIB_DIR}/junit4.jar" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since line 49 is using `${LIB_DIR}/junit4.jar" directly, do we still need to set this property here? Same for other two files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the line <property name="junit4.jar" location="${LIB_DIR}/junit4.jar" />
.
Grinder link:
TARGET: testList TESTLIST=MBCS_Tests_datetime_0,MBCS_Tests_datetime_formatter_0
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43550/
special.functional
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43554/console
- Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist. related: adoptium#5569 Signed-off-by: Anna Babu Palathingal <[email protected]>
ca0713f
to
35ea464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please back port this change to the v1.0.4 release branch. Thanks |
- Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist. related: adoptium#5569 Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia PR: 5644 to backport changes to https://github.com/adoptium/aqa-tests/tree/v1.0.4-release. |
- Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist. related: #5569 Signed-off-by: Anna Babu Palathingal <[email protected]>
related: #5569