Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download dependency libs for MBCS_Tests #5643

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Sep 24, 2024

  • Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist.

related: #5569

@annaibm
Copy link
Contributor Author

annaibm commented Sep 24, 2024

Grinder links:

TARGET: testList TESTLIST=MBCS_Tests_property_utf8_0,MBCS_Tests_language_tag_0
Before:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43524/
After
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43532/

special.functional
Before:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43515/tapTestReport/
After:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43537/

TARGET: testList TESTLIST=MBCS_Tests_datetime_0,MBCS_Tests_datetime_formatter_0
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43535/

@@ -27,13 +27,16 @@ limitations under the License.
<!--Properties for this particular build-->
<property name="src" location="./src" />
<property name="build" location="./bin" />
<property name="junit4.jar" location="${LIB_DIR}/junit4.jar" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since line 49 is using `${LIB_DIR}/junit4.jar" directly, do we still need to set this property here? Same for other two files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the line <property name="junit4.jar" location="${LIB_DIR}/junit4.jar" />.
Grinder link:
TARGET: testList TESTLIST=MBCS_Tests_datetime_0,MBCS_Tests_datetime_formatter_0
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43550/
special.functional
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43554/console

- Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist.

related: adoptium#5569

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm annaibm marked this pull request as ready for review September 24, 2024 20:57
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit a3280ca into adoptium:master Sep 24, 2024
2 checks passed
@llxia
Copy link
Contributor

llxia commented Sep 24, 2024

Please back port this change to the v1.0.4 release branch. Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this pull request Sep 25, 2024
- Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist.

related: adoptium#5569

Signed-off-by: Anna Babu Palathingal <[email protected]>
@annaibm
Copy link
Contributor Author

annaibm commented Sep 25, 2024

@llxia PR: 5644 to backport changes to https://github.com/adoptium/aqa-tests/tree/v1.0.4-release.

llxia pushed a commit that referenced this pull request Sep 25, 2024
- Added junit, testng, jcommander libs to download for MBCS_Tests when prestage libs do not exist.

related: #5569

Signed-off-by: Anna Babu Palathingal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants