-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit OpenJcePlusTests to run with FIPS140-3 profile only #5638
Conversation
This PR is dependent on TKG PR:adoptium/TKG#614 Grinder links: |
@@ -43,8 +43,11 @@ | |||
cp -r ${REPORTDIR}/target/surefire-reports/* junitreports | |||
</command> | |||
<features> | |||
<feature>FIPS140_2:nonapplicable</feature> | |||
<feature>FIPS140_2:nonapplicable</feature> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Line 46
ec9076f
to
c9731a7
Compare
@@ -43,8 +43,10 @@ | |||
cp -r ${REPORTDIR}/target/surefire-reports/* junitreports | |||
</command> | |||
<features> | |||
<feature>FIPS140_2:nonapplicable</feature> | |||
<feature>FIPS140_3_OpenJCEPlusFIPS:required</feature> | |||
<feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:required</feature> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indentation
c9731a7
to
bf3145c
Compare
Grinder links: TARGET:jdk_other TEST_FLAG:FIPS140_3_OpenJCEPlusFIPS.FIPS140-3 TEST_FLAG:FIPS140_3_OpenJCEPlusFIPS TEST_FLAG:FIPS140_2 |
</features> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the extra line.
- Enable if the check for TEST_FLAG contains FIPS140_3_OpenJCEPlusFIPS. - Added feature tags into playlist as required feature. - Required feature Option cannot be used with other feature options related:https://github.ibm.com/runtimes/backlog/issues/1525 Signed-off-by: Anna Babu Palathingal <[email protected]>
bf3145c
to
0679dfc
Compare
Can we update the title to reflect the change? Enable OpenJcePlusTests for FIPS140-3 -> Limit OpenJcePlusTests to run with FIPS140-3 profile only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related:https://github.ibm.com/runtimes/backlog/issues/1525