Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit OpenJcePlusTests to run with FIPS140-3 profile only #5638

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Sep 20, 2024

  • Enable if the check for TEST_FLAG contains FIPS140_3_OpenJCEPlusFIPS.
  • Added feature tags into playlist as required feature.

related:https://github.ibm.com/runtimes/backlog/issues/1525

@annaibm
Copy link
Contributor Author

annaibm commented Sep 20, 2024

This PR is dependent on TKG PR:adoptium/TKG#614

Grinder links:
FIPS140_3_OpenJCEPlusFIPS.FIPS140-3
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43433/
FIPS140_3_OpenJCEPlusFIPS
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/43434

@@ -43,8 +43,11 @@
cp -r ${REPORTDIR}/target/surefire-reports/* junitreports
</command>
<features>
<feature>FIPS140_2:nonapplicable</feature>
<feature>FIPS140_2:nonapplicable</feature>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Line 46

@@ -43,8 +43,10 @@
cp -r ${REPORTDIR}/target/surefire-reports/* junitreports
</command>
<features>
<feature>FIPS140_2:nonapplicable</feature>
<feature>FIPS140_3_OpenJCEPlusFIPS:required</feature>
<feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:required</feature>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation

@annaibm
Copy link
Contributor Author

annaibm commented Sep 24, 2024

@annaibm annaibm requested a review from llxia September 24, 2024 15:11
</features>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra line.

- Enable if the check for TEST_FLAG contains FIPS140_3_OpenJCEPlusFIPS.
- Added feature tags into playlist as required feature.
- Required feature Option cannot be used with other feature options

related:https://github.ibm.com/runtimes/backlog/issues/1525

Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia
Copy link
Contributor

llxia commented Sep 24, 2024

Can we update the title to reflect the change? Enable OpenJcePlusTests for FIPS140-3 -> Limit OpenJcePlusTests to run with FIPS140-3 profile only

@annaibm annaibm changed the title Enable OpenJcePlusTests for FIPS140-3 Limit OpenJcePlusTests to run with FIPS140-3 profile only Sep 24, 2024
@annaibm annaibm marked this pull request as ready for review September 25, 2024 18:06
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit bd69eb5 into adoptium:master Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants