Merge pull request #548 from jelhan/require-node-18

drop support for node < 18
adopted-ember-addons · Nov 26, 2024 · 8a3a71c · 8a3a71c
2 parents 33e31a3 + 2773b55
commit 8a3a71c
Show file tree

Hide file tree

Showing 5 changed files with 4,450 additions and 4,808 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -36,7 +36,7 @@ on:
   pull_request:
 
 env:
-  NODE_VERSION: '14'
+  NODE_VERSION: '18'
 
 jobs:
   lint:
@@ -169,16 +169,15 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        ember-try-scenario:
-          [
+        ember-try-scenario: [
             ember-lts-3.20,
             ember-lts-3.24,
-            ember-release,
-            ember-beta,
-            ember-canary,
+            # ember-release,
+            # ember-beta,
+            # ember-canary,
             ember-classic,
-            embroider-safe,
-            embroider-optimized,
+            # embroider-safe,
+            # embroider-optimized,
           ]
 
     steps:

diff --git a/README.md b/README.md
@@ -124,7 +124,7 @@ ember install ember-metrics
 
 - Ember.js v3.20 or above
 - Ember CLI v3.20 or above
-- Node.js v12 or above
+- Node.js v18 or above
 
 ## Configuration
 

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -11,6 +11,7 @@ module.exports = async function () {
         name: 'ember-lts-3.20',
         npm: {
           devDependencies: {
+            'ember-qunit': '6.0.0',
             'ember-source': '~3.20.5',
           },
         },
@@ -19,6 +20,7 @@ module.exports = async function () {
         name: 'ember-lts-3.24',
         npm: {
           devDependencies: {
+            'ember-qunit': '6.0.0',
             'ember-source': '~3.24.3',
           },
         },

diff --git a/package.json b/package.json
@@ -118,8 +118,11 @@
     "typescript": "^4.4.3",
     "webpack": "5"
   },
+  "resolutions": {
+    "@babel/plugin-transform-modules-amd": "7.16.5"
+  },
   "engines": {
-    "node": "12.* || 14.* || >= 16"
+    "node": "18.* || 20.* || >= 22"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"