Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping tree intact when using onlyIncluded flag #150

Merged

Conversation

davearel
Copy link
Contributor

@davearel davearel commented Jan 8, 2017

The onlyIncluded flag seems to be ignoring the existing tree, which makes it impossible to include pod styles or anything that is dynamically created in the build process.

Using the existing tree allows me to include sass files that were dynamically created without losing the performance benefit of only compiling app/styles and explicitly defined node/bower modules.

This modifies the previous PR of #140, and fixes webark/ember-component-css#203

(Thanks to @webark for the proposed fix)

@simonexmachina
Copy link
Collaborator

Nice one @davearel. Thanks!

@simonexmachina simonexmachina merged commit 63957ba into adopted-ember-addons:master Jan 9, 2017
@simonexmachina
Copy link
Collaborator

I'm not using ember-component-css on any of my projects. I presume you've tested this manually?

@webark
Copy link
Contributor

webark commented Jan 9, 2017

@aexmachina i tested it already, and worked great! thanks for this!

@simonexmachina
Copy link
Collaborator

Cool! Published v6.1.0.

@davearel
Copy link
Contributor Author

davearel commented Jan 9, 2017

Thanks @aexmachina and @webark!

@garryyao
Copy link

garryyao commented Jan 6, 2018

@davearel Hi Dav, would you mind share your configuration on ember-cli-sass, I still have this problem for some reason when using the "onlyIncluded" feature, my pkg versions are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass includePaths
4 participants