Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #5

Merged
Merged

Conversation

stefanpenner
Copy link
Collaborator

  • upgrade broccoli-caching-writer
  • improve promise usage
  • add semi-colons for performance

once ember-cli/broccoli-caching-writer#58 we will get a nice little boost.
More talk about performance: adopted-ember-addons/ember-cli-sass#74

* improve promise usage
* add semi-colons for performance
@simonexmachina
Copy link
Collaborator

Haha, yeah those semicolons should really turbocharge those codes. That code style was actually inherited from broccoli-sass, with the goal of merging back at some point in the future. But I think that this module will just be closed if and when broccoli-sass gets source maps support again, so I'm okay with the deviation.

simonexmachina added a commit that referenced this pull request Sep 16, 2015
@simonexmachina simonexmachina merged commit 78fb285 into adopted-ember-addons:master Sep 16, 2015
@simonexmachina
Copy link
Collaborator

Hey Stef, would you like to be a collaborator on this project? I'm working in native mobile land at the moment, so it's difficult for me to devote much time to Ember stuff.

@simonexmachina
Copy link
Collaborator

Shouldn't there be a package.json update too?

@simonexmachina
Copy link
Collaborator

Doesn't look like this is ready for release yet?

@stefanpenner
Copy link
Collaborator Author

Sure, I'll gladly help maintain.

Oops ya I needed to update package.json. I guess I Linked locally.

The unreleased part of bcw aren't needed. They will merely be a nice additive improvement (no API change)

@simonexmachina
Copy link
Collaborator

Okay is this a major, minor or patch update to bssm?

I'll add you to the Github and NPM packages now.

@simonexmachina
Copy link
Collaborator

That's done.

@stefanpenner
Copy link
Collaborator Author

This one should be minor version bump

@simonexmachina
Copy link
Collaborator

I've published v1.3.0.

@simonexmachina
Copy link
Collaborator

Should I push an update to ember-cli-sass? Be aware that I'm relying on your testing!

@stefanpenner
Copy link
Collaborator Author

Should I push an update to ember-cli-sass? Be aware that I'm relying on your testing!
Delete branch

lets wait to add tests to both the repos, likely better to do that anyways.

I was making these changes in an app, so it continued to work. But if we get regressions in the wild, i would much rather fix them against a test suite. I'll try to make some time over the next few days.

@simonexmachina
Copy link
Collaborator

Amen to that!​

@stefanpenner stefanpenner deleted the upgrade-bcw branch September 17, 2015 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants