considerable speedup #282
considerable speedup #282
Conversation
| sep = "" | ||
| )) | ||
| values(res)<-1 | ||
| spdf <- (spTransform(rasterToPoints(res,spatial=T), localCrs)) |
There was a problem hiding this comment.
This is currently the only use of scan_to_spdf(). Here you take your input raster, convert it to a spdf, and transform it to an aeqd projection (spdf <- (spTransform(rasterToPoints(res,spatial=T), localCrs))). Wouldn't it be more user-friendly if the new scan_to_spdf() takes this raster and CRS as inputs (instead of an spdf that isn't very well defined as input)? Function structure would then be more similar as scan_to_raster().
Also: note that rasterToPoints() throws out any raster points with NA values, is that the desired behaviour? If so, please explain in documentation what kind of values should be in the input raster of the res argument.
| #' convert a polar scan into a raster | ||
| #' | ||
| #' convert an object of class 'scan' into a raster of class 'RasterBrick' | ||
| #' @inheritParams scan_to_raster | ||
| #' @param spdf an input object of class SpatialPointsDataFrame | ||
| #' @return an object of class SpatialPointsDataFrame. FIXME: not clear what kind of spdf is expected here | ||
| #' @details FIXME: to be added | ||
| #' @export | ||
| #' @examples | ||
| #' FIXME: to be added |
There was a problem hiding this comment.
Please add roxygen header with title, description, details, and example
| #' @details FIXME: to be added | ||
| #' @export | ||
| #' @examples | ||
| #' FIXME: to be added | ||
| scan_to_spdf <- function(scan, spdf, param, lat, lon, k = 4 / 3, re = 6378, rp = 6357) { |
There was a problem hiding this comment.
Let's think of a better name that makes clear you are projecting onto something that you provide as input, not simply a one-to-one conversion of a scan to a spatialpointsdataframe (which is what scan_to_spatial() does)
|
moved to issue #293 |
Continuing #278 in a branch native to this repository