commerce: add OST tests cases for Jenkins #426
Conversation
|
|
||
| const page = await browser.newPage(); | ||
| // const requestGnavPromise = page.waitForResponse('https://www.adobe.com/libs/blocks/global-navigation/utilities/keyboard/mainNav.js'); | ||
| await page.goto('https://www.adobe.com/creativecloud/plans.html?mboxDisable=1&adobe_authoring_enabled=true'); |
There was a problem hiding this comment.
are you sure you want this to be run on production?
There was a problem hiding this comment.
@JackySun9 essentially yes, given that the adobeIMS token can be retrieved from dexter (AEM) pages only. I could run it on www.stage.adobe.com but lot of development testing, pricing changes and milo migrations are ongoing on that environment, preparing for the future. We could run into the need of more frequent maintenance of these tests.
Any specific reason or concern why not to run on prod page?
selectors/milo/ost.tools.page.js
Outdated
| this.priceStrikethroughUse = page.locator('button:near(:text("Strikethrough price"))').first(); | ||
| this.checkoutTab = page.locator('//div[@data-key="checkout"]'); | ||
| this.checkoutLink = page.locator('//a[@data-type="checkoutUrl"]'); | ||
| // this.workflowMenu = page.locator('//div//label[contains(text(), "Workflow")]'); |
There was a problem hiding this comment.
@Dli3 Not for now. Removed all commented lines.
tests/milo/ost.tools.test.js
Outdated
| features[0].url = 'https://www.adobe.com/creativecloud/plans.html?mboxDisable=1&adobe_authoring_enabled=true'; | ||
| await ims.fillOutSignInForm(features[0], page); | ||
| await page.waitForLoadState('domcontentloaded'); | ||
| await page.waitForTimeout(3000); |
There was a problem hiding this comment.
Using https://playwright.dev/docs/test-assertions#expecttopass might be a good alternative to this fixed delay. It could proceed earlier or wait longer as needed.
tests/milo/ost.tools.test.js
Outdated
| }); | ||
|
|
||
| await test.step('Enter Offer ID in the search field', async () => { | ||
| await OST.searchField.waitFor({ state: 'visible', timeout: 10000 }); |
There was a problem hiding this comment.
I don't think you need this waitFor line thanks to the fill method's auto-waiting feature. It should wait for the field to be visible out of the box.
There was a problem hiding this comment.
Thanks. Will give it a try. I was just precautious because of the stability.
Adding tests cases for Offer Selector Tool to be able to run them on Jenkins, but skipping them for any github actions