warriors: update and activate commerce tests #418
Conversation
|
Today has been merged to milo main the PR that removes CORS issues for commerce prices and CTAs on branches. I have updated and activated commerce tests so that they could run on PRs now. When i run locally, those tests are passing. However, here they are failing the same as before. Does this repo needs some code syncing with milo repo? Do you have idea what could cause that the prices are still not visible for the run here? One of the tests pages for example: https://main--milo--adobecom.hlx.live/drafts/nala/features/commerce/promo-placeholders (prices are visible now) EDIT: they are failing only in chromium, but passing in firefox ?! |
tests/milo/commerce.feature.test.js
Outdated
| @@ -19,6 +19,8 @@ test.beforeEach(async ({ page, baseURL }) => { | |||
| }); | |||
|
|
|||
| test.describe('Commerce feature test suite', () => { | |||
| test.skip(({ browserName }) => browserName === 'chromium', 'Skipping tests for Chrome browser'); | |||
There was a problem hiding this comment.
If this works locally for you, you could add a condition to skip if process.env.ci is true and it's running on chromium. This way, you can still run against chromium locally.
@afmicka
There was a problem hiding this comment.
@Dli3 did i add the condition wrongly? It did not help, failed here again.
There was a problem hiding this comment.
Looks like process.env.ci didn't work here. But if (browserName === 'chromium' && process.env.GITHUB_ACTIONS) test.skip() did.
|
please fix all lint errors |
|
Thanks @JackySun9 . Was trying different approaches with @Dli3 to skip tests only on github actions. We found the right one and all is good. Once approved, will merge it. |
CORS issues for commerce prices and CTAs have been removed.
Updating and activating commerce tests for milo PRs.
MWPW-157416