Adding lib tests #392
Merged
Adding lib tests #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon32
reviewed
Jul 10, 2024
tests/bacom/libs.test.js
Outdated
Comment on lines
22
to
24
| await context.storageState({ path: authFile }); | ||
| await page.waitForLoadState('networkidle'); |
There was a problem hiding this comment.
Should storageState be after waitForLoadState?
Brandon32
reviewed
Jul 10, 2024
tests/bacom/libs.test.js
Outdated
| await page.goto('https://main--bacom--adobecom.hlx.page/'); | ||
|
|
||
| // Uncomment the line below and run in debug mode to update the authFile (login to Okta manually). | ||
| // await page.waitForTimeout(1000 * 60 * 2); |
There was a problem hiding this comment.
Maybe you could check if options is empty then wait for timeout?
Brandon32
approved these changes
Jul 10, 2024
skumar09
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWPW-154053
Adding lib tests to check which libs are being used.
Note: You may need to run it once to go through okta login once. Afterwards, the authFile should be updated and you can then run in headless mode.