Spec home page #391
Merged
Spec home page #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into spec-homepage
…into spec-homepage
Dli3
reviewed
Jul 9, 2024
| @@ -0,0 +1,35 @@ | |||
| import { test, beforeEach, afterEach, expect } from '@playwright/test'; | |||
There was a problem hiding this comment.
I don't believe you need to import beforeEach and afterEach. You can use test.beforeEach and test.afterEach.
There was a problem hiding this comment.
Hi @Dli3, I have addressed the above comment and pushed the code.
Dli3
reviewed
Jul 9, 2024
| }); | ||
| features.forEach((props) => { | ||
| test(`${props.name}, ${props.tags}, ${props.country}`, async ({ page, baseURL }) => { | ||
| console.info(`[FEDSInfo] Checking Page: ${props.country} = ${baseURL}${features[props.tcid].path}`); |
There was a problem hiding this comment.
Can't you just do props.path?
${baseURL}${props.path});`
There was a problem hiding this comment.
Hi @Dli3, I have addressed the above comment and pushed the code.
JackySun9
approved these changes
Jul 15, 2024
Dli3
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sigadamvenkata, I have updated the "Home Page" Selector and added iOS, Android, and iPad methods in the same page.
Local Test Run iOS Results
Local Test Run Android Results
