-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncing with master #222
Closed
Closed
syncing with master #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Todo statement Added Todo statement for method that needs to be fixed for feature addition. * updated buildUrl updated buildUrl to check if branch has directory path, if so I split it upon that directory. * Removed Todo Statement Removed Todo Statement * updated branch creation updated branch creation to support any length of directory paths.
updated readme to have the correct multiple tag execution
Fix for modal not showing up when directly navigating to the #<url> when using milolibs url parameter.
* removed unnecessary awaits removed unnecessary awaits * added scroll method and soft expect added scroll method and removed hover method, changed expect to soft expect.
* custom-reporters impl * use custom-reporters * cleanup for pr --------- Co-authored-by: Jingle Huang <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
* First DC test * Update DC env * Add preview and download step * acceptDownloads is not needed * Add DC stage and prod domains, update tags and selectors * Specify file type otherwise file upload is flaky * Update converter block selectors * Check if the converter block failed to load * Add checking if converter is visible * Increase timeout for CI debugging * Stage URLs can only be tested on VPN * Update converter widget selector * Internal pages have known CORS issues --------- Co-authored-by: Aaron Mauchley <[email protected]>
Updated github actions for upload-artifact to latest version v3.
added faas html extension test
Added more test cases to html extension test
updated README to include missing install step.
Co-authored-by: Dennis Li <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
fixed IMS login test bacom prod url, removed unnecessary awaits.
* Fix URL for DC PR testing * Test the full URL with .html in DC * Use the new repoName variable instead & move .html in spec.js --------- Co-authored-by: Aaron Mauchley <[email protected]>
Co-authored-by: Aaron Mauchley <[email protected]>
* changed environment naming Added repoName pulling, and changed environment domain name tags to coincide with hlx endings. * updated parse.js to pull repository name updated parse.js to pull repository name to know which owner has executed Nala. This allows PR testing for consumers.
Added stage url check
* Removed workaround for CSP issue Removed workaround for CSP issue with DC hlx.* urls when testing for Milo or any other consuming site but DC's repository. * Update regex for URLs with milolibs query param --------- Co-authored-by: John Fernandez <[email protected]>
* [MWPW-126307] Added FEDS consent spec file * [MWPW-126307] Added FEDS consent selectors (wip) * [MWPW-126307] Added FEDS envs | consent first check * [MWPW-126307] Updated envs/tags to support amauch suggestions * [MWPW-126307] Updated logic to support new FEDS consent checks * [MWPW-126307] Updated envs.js * [MWPW-126307] Updated COMMENT to reflex @narcis comment specifications * [MWPW-126307] Undo parse.js change --------- Co-authored-by: Dan Chivescu <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
* updated playwright and dependencies updated playwright and dependencies to latest versions * updated playwright and dependencies updated playwright and dependencies * added temporary condition to modal test added temporary condition to modal test for webkit where playwright v1.30.0 has an issue with keyboard input. * removed conditional against webkit removed conditional against webkit, logged a bug with Playwright about how webkit modals/embedded videos not having tab focus. * updated deps to latest versions again updated dev deps and playwright to latest version. * updated axios and playwright versions updated axios and playwright versions to latest.
* L1 verbs tests * Add more L2 verbs * Add L1 verbs tests * Increase the timeout for Google YOLO button * Ignore output files * Include all Converter Block tests in Frictionless tests * Check the one-tap prompt in Firefox and Webkit * Google sign-in prompt does not work in Helix URLs * Increase the timeout due to a known bug * Wait for the 'filechooser' event before opening it * Create a random test password --------- Co-authored-by: Aaron Mauchley <[email protected]>
* syncing up with main (#62) * Updated github actions for upload-artifact (#58) Updated github actions for upload-artifact to latest version v3. * updated README (#60) updated README to include missing install step. * added rest of test cases for html ext testing added rest of test cases for html ext testing, changed spec files to use hlx.live urls, * Added link navigation check Added link navigation check * updated methods to fix issues and PR review added blog production environment, changed contains to includes for string checking, added awaits where necessary, made adjustments according to PR review. * updated faas environments to use new tag naming updated faas environments to use new tag naming * updated test to address failures updated test to address failures * updated faas test updated faas test for .html testing --------- Signed-off-by: Aaron Mauchley <[email protected]>
* updated config for parallel runs and matrix runs updated config for parallel runs and matrix runs against windows, mac, and linux for github actions. * Added OS into title Added OS into title * updated fail-fast logic, removed matrix on PRs updated fail-fast logic, removed matrix on PRs * changed parallel runs to 3 changed parallel runs to 3 * adjusted parallel runs to 2 adjusted parallel runs to 2 * reverted parallel executions in CI. reverted parallel executions in CI. * updated back to 3 parallel executions updated back to 3 parallel executions * moved it back to 2, WIP moved it back to 2, WIP * reverted parallel runs reverted parallel runs
…in classnames (#74) Co-authored-by: Aaron Mauchley <[email protected]>
added staging environment for BACOM
* MWPW-127667 Update playwright configuration * updating actionTimeout * updating .gitignore and actionTimeout * remove html result index.html * updated actiontimeout-2 --------- Co-authored-by: nateekar <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
This PR addresses failures in the daily runs as well as adds missing failed block tests for DC. Most of the tests in the daily runs were failing due to internal network access denied issues and browser bot issues. These tests are being skipped temporarily until a solution is in place that will work.
* [MWPW-136596] Added FEDS VC checks * [MWPW-136596] Added VC config file * [MWPW-136596] Updated VC checks * [MWPW-136596] Updated FEDS VC checks --------- Co-authored-by: Aaron Mauchley <[email protected]>
* commenting linux-webkit project * commenting the project --------- Co-authored-by: nateekar <[email protected]>
* commit helpx internal procedure component * Incorporating review comments * commit beforeAfter changes * handled scenario if auth token not set in env variable * CodeBlock and Draft cases * Reviews * Committing config changes * Update helpx.config.js --------- Co-authored-by: Santoshkumar Nateekar <[email protected]>
* add video test to modal and update marquee console fn * testing token * update the console log --------- Co-authored-by: nateekar <[email protected]>
* merch-cards test scripts * remove webhook url * update the url * updated eof space * updated the locator --------- Co-authored-by: nateekar <[email protected]>
card-block-scripts Co-authored-by: nateekar <[email protected]>
chart test scripts Co-authored-by: nateekar <[email protected]>
* tabs-block-scripts * disable price validation from merch cards --------- Co-authored-by: nateekar <[email protected]>
* [MWPW-138268] Added Promobar logic & selectors * [MWPW-138268] Added Promobar test file & PO * [MWPW-13868] Removed unnecessary spec config * [MWPW-138268] Adressing PR reviews --------- Co-authored-by: Aaron Mauchley <[email protected]>
* table block test scripts * spell correct * remove comments * remove additional spaces and comments --------- Co-authored-by: nateekar <[email protected]>
* update to run on circleci * update comment --------- Co-authored-by: nateekar <[email protected]>
* action-item-scripts * comment update * remove extra space * update the review comment * update the action-item-count * update type * updated circleci url --------- Co-authored-by: nateekar <[email protected]>
fix circle-ci url Co-authored-by: nateekar <[email protected]>
* fix circle-ci url * update the circle url --------- Co-authored-by: nateekar <[email protected]>
…erce v3 Merch Card (#212) * fix circle-ci url * update merch cards scripts --------- Co-authored-by: nateekar <[email protected]>
…el is added (#215) [MWPW-139561] FEDS to Milo - critical components checks
* add test for quiz and result pages * add test for quiz and result pages * add test for quiz and result pages * add POC for analytics test * update analytics tests and envs * result envs * update analytics only on firefox * add dynamic tests * add dynamic test for quiz page * update quiz test * update test structure * add test for quiz and result pages * add POC for analytics test * update analytics tests and envs * result envs * update analytics only on firefox * add dynamic tests * add dynamic test for quiz page * update quiz test * update test structure * update uar tests to new format * update uar tests * move everything to uar folder * add dependency for js-yaml * update test according to latest comments * update test according to latest comments * update tests according to the latest comments * add uar config * add analytics for uar * update according to feedbacks * update tags * add @cc tag * update according to feedbacks * add dynamic tests for uar * update according to review comments * fix some typos * update according to review comments * merge console log info * add UI screenshots for UAR * move view point to test * update according to feedback * add analytics test for UAR * update validation and uar libs * update libs * update by feedback * update some config and tests * update some config and tests * update test content path to common path * update analytics tests * fix test failures caused by test code * fix test failures * fix test failures * add visual test for CAAS with two pages * update according to feedbacks * update report in config file --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
* config, env, folder structure setup for CC config, env, folder structure setup for CC onboarding * PR 126 - Review comments changes PR 126 - Review comments changes * PR 126 asked changes PR 126 asked changes * Update febpub.sanity.js * Update fedpub.sanity.js * Update febpub.selectors.js * Update febpub.test.js * Text block legal, link-farm variations automation Text block legal, link-farm variations automation * removed unwanted comma as per comments removed unwanted comma as per comments * moved the new case details to new line as per review comments moved the new case details to new line as per review comments * Jarvis feature Automated test cases MWPW-122175 : jarvis feature automation test cases * OST Price formats (single license, month/year subscriptions, strikethrough preice, student license, Ucv3 checkout cases automation OST Price formats (single license, month/year subscriptions, strikethrough price, student license, Ucv3 (email, segmentation, upsell etc) checkout flows automation. Jira: https://jira.corp.adobe.com/browse/MWPW-135460 * javis feature file removed * spec javis removed * test javis removed * Update ostprices.spec.js * Update ostprices.page.js updated file with given changes * Update ostprices.test.js added required changes --------- Co-authored-by: Dan Chivescu <[email protected]> Co-authored-by: Santoshkumar Nateekar <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
* add test for quiz and result pages * add test for quiz and result pages * add test for quiz and result pages * add POC for analytics test * update analytics tests and envs * result envs * update analytics only on firefox * add dynamic tests * add dynamic test for quiz page * update quiz test * update test structure * add test for quiz and result pages * add POC for analytics test * update analytics tests and envs * result envs * update analytics only on firefox * add dynamic tests * add dynamic test for quiz page * update quiz test * update test structure * update uar tests to new format * update uar tests * move everything to uar folder * add dependency for js-yaml * update test according to latest comments * update test according to latest comments * update tests according to the latest comments * add uar config * add analytics for uar * update according to feedbacks * update tags * add @cc tag * update according to feedbacks * add dynamic tests for uar * update according to review comments * fix some typos * update according to review comments * merge console log info * add UI screenshots for UAR * move view point to test * update according to feedback * add analytics test for UAR * update validation and uar libs * update libs * update by feedback * update some config and tests * update some config and tests * update test content path to common path * update analytics tests * fix test failures caused by test code * fix test failures * fix test failures * add visual test for CAAS with two pages * update according to feedbacks * update report in config file * add screenshot for milo main live vs uar-integration live * add timestamp js for time stampe recording * add screenshot diff for uar stable and beta * move uar screenshots into visual compare folder --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]>
…#211) * fix circle-ci url * analytics update 2_1 * update text.block.spec * fix circle-ci url * update circle ci --------- Co-authored-by: nateekar <[email protected]>
* fix circle-ci url * personalization test cases * update review comments * update the merch cards changes * update pzn test case --------- Co-authored-by: nateekar <[email protected]>
… runs (#218) * update cc tests and add daily run * testing the scheduler --------- Co-authored-by: nateekar <[email protected]>
* add test for quiz and result pages * add test for quiz and result pages * add test for quiz and result pages * add POC for analytics test * update analytics tests and envs * result envs * update analytics only on firefox * add dynamic tests * add dynamic test for quiz page * update quiz test * update test structure * add test for quiz and result pages * add POC for analytics test * update analytics tests and envs * result envs * update analytics only on firefox * add dynamic tests * add dynamic test for quiz page * update quiz test * update test structure * update uar tests to new format * update uar tests * move everything to uar folder * add dependency for js-yaml * update test according to latest comments * update test according to latest comments * update tests according to the latest comments * add uar config * add analytics for uar * update according to feedbacks * update tags * add @cc tag * update according to feedbacks * add dynamic tests for uar * update according to review comments * fix some typos * update according to review comments * merge console log info * add UI screenshots for UAR * move view point to test * update according to feedback * add analytics test for UAR * update validation and uar libs * update libs * update by feedback * update some config and tests * update some config and tests * update test content path to common path * update analytics tests * fix test failures caused by test code * fix test failures * fix test failures * add visual test for CAAS with two pages * update according to feedbacks * update report in config file * add screenshot for milo main live vs uar-integration live * add timestamp js for time stampe recording * add screenshot diff for uar stable and beta * move uar screenshots into visual compare folder * add UI screenshots for DX Quiz * build a function to get screenshots --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: xiasun <[email protected]>
update cc workflow Co-authored-by: nateekar <[email protected]>
* updat to cc-workflow * also update the headerblock script --------- Co-authored-by: nateekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.