Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dynamic test cases for UAR #156

Merged
merged 83 commits into from
Aug 31, 2023
Merged

Create dynamic test cases for UAR #156

merged 83 commits into from
Aug 31, 2023

Conversation

JackySun9
Copy link
Contributor

https://jira.corp.adobe.com/browse/MWPW-134029
https://jira.corp.adobe.com/browse/MWPW-124778

  1. build test data for manual and automation
  2. build test cases according to source json files
  3. build automation based on dynamic test data
  4. run automation side by side on prod and uar-integration

xiasun and others added 30 commits February 28, 2023 10:06
add test for quiz and result pages
17a42c8
add test for quiz and result pages
5b40dd7
Merge branch 'main' of https://github.com/JackySun9/nala
7f53c91
@amauch-adobe
Merge branch 'main' into main
91dea1c
@amauch-adobe
Merge branch 'main' into main
6cabde1
@amauch-adobe
Merge branch 'main' into main
e93dc78
@amauch-adobe
Merge branch 'main' into main
92c4926
add test for quiz and result pages
40e1c70
Merge branch 'main' of https://github.com/JackySun9/nala
fef7e83
add POC for analytics test
6a597e1
update analytics tests and envs
83436c5
result envs
6dcc5bf
update analytics only on firefox
90ce636
@amauch-adobe
Merge branch 'main' into main
d178ea2
@amauch-adobe
Merge branch 'main' into main
7709d2f
add dynamic tests
146cb59
@amauch-adobe
Merge branch 'main' into main
7c8125b
@amauch-adobe
Merge branch 'main' into main
73917e0
add dynamic test for quiz page
676a6ed
@amauch-adobe
Merge branch 'main' into main
fb62f2f
update quiz test
a5a1386
@amauch-adobe
Merge branch 'main' into main
17d8de5
@amauch-adobe
Merge branch 'main' into main
613a53e
@amauch-adobe
Merge branch 'main' into main
d9dc819
@amauch-adobe
Merge branch 'main' into main
c4f46fd
@amauch-adobe
Merge branch 'main' into main
3b6beb9
update test structure
de7b82c
@amauch-adobe
Merge branch 'main' into main
e33d1ff
@amauch-adobe
Merge branch 'main' into main
8228063
@amauch-adobe
Merge branch 'main' into main
34eef21
amauch-adobe
amauch-adobe requested changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments throughout.

features/uar/quiz.dynamic.spec.js Show resolved Hide resolved
features/uar/quiz.dynamic.spec.js Show resolved Hide resolved
libs/webutil.js Show resolved Hide resolved
selectors/uar/quiz.old.page.js Show resolved Hide resolved
selectors/uar/quiz.old.page.js Outdated Show resolved Hide resolved
selectors/uar/quiz.old.page.js Outdated Show resolved Hide resolved
selectors/uar/quiz.page.js Show resolved Hide resolved
selectors/uar/quiz.page.js Outdated Show resolved Hide resolved
tests/uar/quiz.dynamic.test.js Outdated Show resolved Hide resolved
tests/uar/quiz.dynamic.test.js Outdated Show resolved Hide resolved
amauch-adobe
amauch-adobe requested changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my one question, but excellent job on the changes.

package.json Outdated Show resolved Hide resolved
skumar09
skumar09 requested changes Aug 28, 2023
View reviewed changes
selectors/uar/quiz.old.page.js Show resolved Hide resolved
selectors/uar/quiz.page.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
chadsunvice
chadsunvice approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@chadsunvice chadsunvice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, but overall looks great @JackySun9!

selectors/uar/quiz.old.page.js Outdated Show resolved Hide resolved
selectors/uar/quiz.page.js Outdated Show resolved Hide resolved
selectors/uar/quiz.old.page.js Show resolved Hide resolved
amauch-adobe
amauch-adobe approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@JackySun9 JackySun9 merged commit 7bcfd79 into adobecom:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadsunvice chadsunvice chadsunvice approved these changes

@amauch-adobe amauch-adobe amauch-adobe approved these changes

@skumar09 skumar09 skumar09 approved these changes

@Dli3 Dli3 Awaiting requested review from Dli3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackySun9 @skumar09 @amauch-adobe @chadsunvice