[MWPW-133606] Aside block automated scripts #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amauch-adobe
requested changes
Aug 14, 2023
JackySun9
requested changes
Aug 15, 2023
JackySun9
approved these changes
Aug 16, 2023
Updated! |
skumar09
reviewed
Aug 21, 2023
There was a problem hiding this comment.
@chadsunvice: PR looks good; just following a few points
- do we want to add CSS / attributes validations, Or do you want to take care later?
skumar09
reviewed
Aug 21, 2023
…e_block_automation
I talked to Narcis and also got some feedback from our Devs that there are still Aside changes happening so this will mean most of the checks will become brittle. I would wait for development to stabilise and then take some conclusions on this. Also we feel CSS validation isn't something that will change, and attributes are already tested via the selectors that have them in their composition. So I would say wait on this. |
skumar09
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR raised in scope of ticket [MWPW-133606]: Aside Block: Create Nala Automation Test script .