Skip to content

Commit

Permalink
[ Daily Run] Carouse block script fix for Windows platform (#149)
Browse files Browse the repository at this point in the history
* update-4

* carousel daily run fix

* remove manual.yml

---------

Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
  • Loading branch information
3 people authored Aug 4, 2023
1 parent 75b0dda commit 92d0fe9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
6 changes: 3 additions & 3 deletions features/milo/carousel.block.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ module.exports = {
BlockName: 'Carousel Block',
features: [
{
tcid: '1',
tcid: '0',
name: '@Carousel(container)',
path: '/drafts/nala/blocks/carousel/lightbox',
tags: '@carousel @carousel-container @smoke @regression @milo',
envs: '@milo-live @milo-prod',
},
{
tcid: '2',
tcid: '1',
name: '@Carousel(lightbox)',
path: '/drafts/nala/blocks/carousel/fullpage-carousel',
tags: '@carousel @carousel-container @smoke @regression @milo',
envs: '@milo-live milo-prod',
},
{
tcid: '3',
tcid: '2',
name: '@Carousel Multi slide(show-2)',
path: '/drafts/nala/blocks/carousel/carousel-show-2',
tags: '@carousel @carousel-container @regression @milo',
Expand Down
5 changes: 5 additions & 0 deletions selectors/milo/carousel.block.page.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,18 +197,23 @@ export class Carousel {
let isDisplayed;
switch (type) {
case 'carouselLightbox':
await this.carouselLightbox.waitFor({ state: 'visible' });
isDisplayed = await this.carouselLightbox.isVisible();
break;
case 'carouselFullpage':
await this.carouselFullpage.waitFor({ state: 'visible' });
isDisplayed = await this.carouselFullpage.isVisible();
break;
case 'carouselContainer':
await this.carouselContainer.waitFor({ state: 'visible' });
isDisplayed = await this.carouselContainer.isVisible();
break;
case 'carouselShow-2':
await this.carouselContainerShow2.waitFor({ state: 'visible' });
isDisplayed = await this.carouselContainerShow2.isVisible();
break;
case 'carousel':
await this.carouselDefault.waitFor({ state: 'visible' });
isDisplayed = await this.carouselDefault.isVisible();
break;
default:
Expand Down
6 changes: 3 additions & 3 deletions tests/milo/carousel.block.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test.describe('Milo Carousel Block test suite', () => {
});

test(`${features[0].name},${features[0].tags}`, async ({ page, baseURL }) => {
console.info('[Test Page]: ', baseURL);
console.info(`[Test Page]: ${baseURL}${features[0].path}`);

await test.step('step-1: Go to Carousel block test page', async () => {
await page.goto(`${baseURL}${features[0].path}`);
Expand Down Expand Up @@ -50,7 +50,7 @@ test.describe('Milo Carousel Block test suite', () => {
});

test(`${features[1].name},${features[1].tags}`, async ({ page, baseURL }) => {
console.info('[Test Page]: ', baseURL);
console.info(`[Test Page]: ${baseURL}${features[0].path}`);

await test.step('step-1: Go to Carousel lightbox block test page', async () => {
await page.goto(`${baseURL}${features[1].path}`);
Expand Down Expand Up @@ -83,7 +83,7 @@ test.describe('Milo Carousel Block test suite', () => {
});

test(`${features[2].name},${features[2].tags}`, async ({ page, baseURL }) => {
console.info('[Test Page]: ', baseURL);
console.info(`[Test Page]: ${baseURL}${features[2].path}`);

await test.step('step-1: Go to Carousel multi-slide show-2 block test page', async () => {
await page.goto(`${baseURL}${features[2].path}`);
Expand Down

0 comments on commit 92d0fe9

Please sign in to comment.