generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-159924 [CAI] | Integrate SDK (PIN & Modal) into Homepage #3210
Open
sharmrj
wants to merge
19
commits into
adobecom:stage
Choose a base branch
from
sharmrj:cai
base: stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+711
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initiation into processSection
sharmrj
requested review from
jenssingler,
overmyheadandbody,
bandana147 and
mokimo
November 18, 2024 10:48
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #3210 +/- ##
==========================================
- Coverage 96.37% 96.36% -0.02%
==========================================
Files 245 246 +1
Lines 56716 56883 +167
==========================================
+ Hits 54661 54815 +154
- Misses 2055 2068 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAI
prefix on the img alt text (delimited from the actual alt text by a|
)cai-toolkit.wasm
file and thecai-worker.min.js
files in the deps folder in milo. Since most of the computation takes place inside a worker spawned bycai-worker.min.js
, we needn't worry about spawning our own worker thread.signatureInfo.issuer
field of theactiveManifest
.signatureInfo.time
field of theactiveManifest
.selectGenerativeInfo(activeManifest)
function from the c2pa sdk.compositeWithTrainedAlgorithmicMedia
, it supercedes all other types, and we give back the corresponding message as found in https://cv.iptc.org/newscodes/digitalsourcetype/compositeWithTrainedAlgorithmicMediaselectFormattedGenerator(activeManifest)
function from the c2pa sdk.en_US
is supported[0] - The query parameters tell the CDN which optimized version of the image needs to be served. Unfortunately the CDN strips away all metadata from the image when optimizing it, so the c2pa metadata is lost. However, without the query parameters the unoptimized image with the correct metadata is pointed to. In order to minimize LCP impact while still allowing the user to download the image and inspect its metadata, we do the first load with the optimized image and swap out the src of the
img
tag. Thesource
tags are left untouched since only the src of theimg
tag matters when the user right clicks and downloads the image. This has been tested at different viewport sizes where different source sets should apply.Analytics will be implemented in a future PR.
Resolves: MWPW-159924
Test URLs:
URL for QA (homepage clone): https://main--homepage--adobecom.hlx.page/homepage/drafts/raghavs/index-loggedout?milolibs=cai--milo--sharmrj
URL for QA (regular milo page): https://cai--milo--sharmrj.hlx.page/drafts/raghavs/cai