MWPW-161273 Standalone Gnav needs a release cycle [Bundle] #3132

sharmrj · 2024-11-04T04:43:35Z

In order to support versioning and a release cadence for the standalone gnav and footer, we've created a dist folder that contains the built files for the standalone gnav.
This was done by making all dynamic imports of javascript explicit and relative
The region nav in the global footer was rrefactored to have it's own modal instead of depending on the milo modal implementation. This had to be done to avoid dynamic imports whose paths had to be generated at runtime, and so could not be picked up by the bundler. There are slight differences in how the css behaves with the new modal since it uses the native HTML element dialog. The implementation was refactored to explicitly load everything in the region-nav.
supercedes MWPW-161273 Standalone Gnav needs a release cycle #3113

Related discussion: https://github.com/orgs/adobecom/discussions/3114

Test URLs:

https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=bundled-standalone-gnav&theme=dark&usebundle=true

…-nav

aem-code-sync · 2024-11-04T04:43:38Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

8d786a0 ✅ (latest)
3265617 ✅
2330b70 ✅
e7fe085 ✅
4f8993c ✅
0ba45a9 ✅
1f684a8 ✅
b21221e ✅
1c52c82 ✅
4ac107c ✅
bdb4d5c ✅
c3a47fa ✅
e38db1a ✅
acf1172 ✅
f251eca ✅
e940057 ✅
0afaceb ✅
534324c ✅
da2a5eb ✅

aem-code-sync · 2024-11-04T04:44:01Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/chunk-P5BLQZYT.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/chunk-TWIEHJXN.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/chunk-V5EBVEYY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/chunk-XA4S2AUY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/chunk-Y4BBGCES.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/chunk-YBWLHNHN.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/compression-streams-pollyfill-BECBJY2B.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/delayed-K4FSJ65U.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/dropdown-6XHPNOOF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/dynamic-navigation-WHBV2U5I.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/entitlements-HZ47ZHLP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/fallback-USUMWIZJ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/favicon-HIJJWFIE.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/federated-WHH22KS6.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/fonts-MZXYV4PH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/footer-promo-WNOQ7YFG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/fragment-2FKKFKOO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/georouting-XMXS5XAF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/georoutingv2-AQOZG7OE.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/global-footer-JSA3TZLL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/global-navigation-LTNRQZHF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/gnav-search-FLFLVG6K.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/google-login-YYHDA5O5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/icons-GYUZ2JYT.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/image-video-link-4SFGX634.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/interlinks-U3ZBSGN7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/japanese-word-wrap-JPHCD7GU.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/jarvis-chat-7JAHTS6A.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/keyboard-ICZXWIKH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/lana-CJYS67OO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/links-FPVW2SRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/locales-B55ON6DW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/logWebVitals-2FUT43AM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/martech-OGSEOXFX.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/martech-metadata-IFKUKRUK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/menu-OU4LBNRW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/modal-7AHCVFRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/modal.merch-WCIHPIXJ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/navigation.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/personalization-BJD6WS5Q.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/placeholders-QGAKCKDM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/preview-6UAFSSNS.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/promo-utils-ZNNK27VM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/region-nav-GPGOEARK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/richresults-43QBE3MW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/samplerum-X27QZ7WO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/send-to-caas-ZSPRJRPY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/seotech-WSNZVBES.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/sidekick-KNP7N6WG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/stage-entitlements-OTT4TEAL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/status-ODL3HCMH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/title-append-T3KFKL6F.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/utils-TZSNABDG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e940057590684828ad08b985136d2de20cb2c3ec/libs/navigation/dist/webapp-prompt-LNKMFAA3.js

🚫 [eslint] <import/no-relative-packages> _{reported by reviewdog 🐶}
Relative import from another package is not allowed. Use navigation/bootstrapper.js instead of ../../libs/navigation/bootstrapper.js

milo/test/navigation/bootstrapper.test.js

Line 4 in e940057

import loadBlock from '../../libs/navigation/bootstrapper.js';

🚫 [eslint] <import/no-relative-packages> _{reported by reviewdog 🐶}
Relative import from another package is not allowed. Use navigation/navigation.js instead of ../../libs/navigation/navigation.js

milo/test/navigation/navigation.test.js

Line 4 in e940057

import loadBlock from '../../libs/navigation/navigation.js';

codecov · 2024-11-04T04:44:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (6664bb2) to head (8d786a0).

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3132      +/-   ##
==========================================
+ Coverage   96.37%   96.39%   +0.02%     
==========================================
  Files         245      245              
  Lines       56607    56647      +40     
==========================================
+ Hits        54554    54606      +52     
+ Misses       2053     2041      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/entitlements-HZ47ZHLP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/fallback-USUMWIZJ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/favicon-HIJJWFIE.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/federated-WHH22KS6.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/fonts-MZXYV4PH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/footer-promo-WNOQ7YFG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/fragment-2FKKFKOO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/georouting-XMXS5XAF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/georoutingv2-AQOZG7OE.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/global-footer-JSA3TZLL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/global-navigation-LTNRQZHF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/gnav-search-FLFLVG6K.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/google-login-YYHDA5O5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/icons-GYUZ2JYT.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/image-video-link-4SFGX634.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/interlinks-U3ZBSGN7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/japanese-word-wrap-JPHCD7GU.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/jarvis-chat-7JAHTS6A.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/keyboard-ICZXWIKH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/lana-CJYS67OO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/links-FPVW2SRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/locales-B55ON6DW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/logWebVitals-2FUT43AM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/martech-OGSEOXFX.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/martech-metadata-IFKUKRUK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/menu-OU4LBNRW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/modal-7AHCVFRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/modal.merch-WCIHPIXJ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/navigation.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/personalization-BJD6WS5Q.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/placeholders-QGAKCKDM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/preview-6UAFSSNS.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/promo-utils-ZNNK27VM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/region-nav-GPGOEARK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/richresults-43QBE3MW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/samplerum-X27QZ7WO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/send-to-caas-ZSPRJRPY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/seotech-WSNZVBES.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/sidekick-KNP7N6WG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/stage-entitlements-OTT4TEAL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/status-ODL3HCMH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/title-append-T3KFKL6F.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/utils-TZSNABDG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f251eca0e5030c26e53249f8a910f310bb2d226e/libs/navigation/dist/webapp-prompt-LNKMFAA3.js

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/global-navigation-LTNRQZHF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/gnav-search-FLFLVG6K.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/google-login-YYHDA5O5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/icons-GYUZ2JYT.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/image-video-link-4SFGX634.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/interlinks-U3ZBSGN7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/japanese-word-wrap-JPHCD7GU.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/jarvis-chat-7JAHTS6A.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/keyboard-ICZXWIKH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/lana-CJYS67OO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/links-FPVW2SRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/locales-B55ON6DW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/logWebVitals-2FUT43AM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/martech-OGSEOXFX.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/martech-metadata-IFKUKRUK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/menu-OU4LBNRW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/modal-7AHCVFRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/modal.merch-WCIHPIXJ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/navigation.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/personalization-BJD6WS5Q.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/placeholders-QGAKCKDM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/preview-6UAFSSNS.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/promo-utils-ZNNK27VM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/region-nav-GPGOEARK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/richresults-43QBE3MW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/samplerum-X27QZ7WO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/send-to-caas-ZSPRJRPY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/seotech-WSNZVBES.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/sidekick-KNP7N6WG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/stage-entitlements-OTT4TEAL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/status-ODL3HCMH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/title-append-T3KFKL6F.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/utils-TZSNABDG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e38db1ab412c779563d71570ac5fa0ed34c64f61/libs/navigation/dist/webapp-prompt-LNKMFAA3.js

mokimo

Cool, I would love if you also opened a discussion highlighting the whole approach of exporting a milo component as standalone one and the expected consumption model, alternatives, thoughts that went into it etc.

It would be very valuable to point to in the future!

mokimo · 2024-11-04T10:12:59Z

libs/navigation/build.mjs

@@ -0,0 +1,20 @@
+import * as esbuild from 'esbuild'; // eslint-disable-line


Just FYI, we also use microbundle for things such as creating the preact-htm bundle

mokimo · 2024-11-04T10:15:39Z

libs/navigation/build.mjs

+  bundle: true,
+  splitting: true,
+  format: 'esm',
+  minify: true,


Do we want to minify the bundle, does it make any sense? Personally I love to debug in chrome directly using overwrites, that would make this a bit more of an entrance barrier for other folks to come and help out / troubleshoot.

Yeah it can save us, overall, a fair few kilobytes (5-10kb), and we can look into generating sourcemaps to help with debugging, and so on. Source maps would be the preferred way of doing this as well since the chunking will mess up our organization of the code anyway, and they'll be loaded automatically only if we open the debugger. We'd just need to add sourcemap: true to the config here, but the tradeoff would be that now we'd be committing even more files to the repo.

github-actions · 2024-11-05T01:35:17Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

…-standalone-gnav

…he current milo modal so that it can be bundled

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/chunk-YLISDLB5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/delayed-WBWBIETS.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/dropdown-L5YAFN25.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/dynamic-navigation-NC73H4NF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/federated-WMN4YKVN.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/footer-promo-DYKXDRHD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/fragment-NEX4AEVV.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/georouting-RSHO26IM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/georoutingv2-DQJXQCQ4.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/global-footer-FPT672UO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/global-navigation-MXCO3KV7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/gnav-search-WMT2JH4A.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/google-login-YYHDA5O5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/icons-GYUZ2JYT.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/image-video-link-YRYHJSIM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/interlinks-U3ZBSGN7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/japanese-word-wrap-CMOPJRX7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/jarvis-chat-7JAHTS6A.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/keyboard-UX5HPW3Y.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/lana-CJYS67OO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/links-FPVW2SRD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/locales-B55ON6DW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/logWebVitals-USVXTFKF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/martech-IXGZRYLI.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/martech-metadata-CBLVY7TB.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/menu-7PIKR52W.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/modal-AN3SJQ56.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/modal.merch-WCIHPIXJ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/navigation.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/personalization-ZOVAUKXO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/placeholders-S7CQTQ4C.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/preview-6IQJ3ZQQ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/promo-utils-K7HI3WSR.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/region-nav-YVHG3J7E.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/richresults-43QBE3MW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/samplerum-X27QZ7WO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/send-to-caas-PUZ2M7FY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/seotech-WSNZVBES.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/sidekick-X42MOA5X.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/status-KDXYKNYO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/title-append-T3KFKL6F.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/utils-57TVUEB7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/bdb4d5cb843b8daefa831a2dea60bc0d5d9caba5/libs/navigation/dist/webapp-prompt-RYOUGT2Y.js

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/locales-PE6ERXTI.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/logWebVitals-NC52TIG5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/martech-IAZXAYEY.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/martech-metadata-6ZESHJKI.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/menu-I3HG374I.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/modal-EFZY44VD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/modal.merch-ILIM5VBD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/personalization-ON6N7TPG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/placeholders-CTN6ZPX7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/preview-LL5SXGTV.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/promo-utils-TBPN5XQU.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/region-nav-R4VABW4G.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/richresults-GAU5FOJP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/samplerum-UMPZCNEM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/send-to-caas-CU6NNK35.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/seotech-UFKMTZPX.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/sidekick-PCCSGDU4.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/status-I6ZR5NJO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/title-append-2CWER3AB.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/utils-5PPNVIT6.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/e7fe085be80623c95665274ad2474e1c08b018e9/libs/navigation/dist/webapp-prompt-SDK5JF5J.js

github-actions · 2024-11-05T06:13:53Z

libs/navigation/dist/google-login-AKYRMXAP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-05T06:13:54Z

libs/navigation/dist/icons-2SSTIN6G.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-05T06:13:55Z

libs/navigation/dist/interlinks-DMZPOFKO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-05T06:13:57Z

libs/navigation/dist/jarvis-chat-6NO6BTW2.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-05T06:13:59Z

libs/navigation/dist/lana-KASNHKUL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-05T06:14:00Z

libs/navigation/dist/links-6DJF7PTH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

salonijain3 · 2024-11-05T10:55:32Z

@mokimo @narcis-radu This needs to be merged to stage on 12/2 and to main to 12/5 to support the production deployment on 12/9.
Release calendar and the cadence is also updated on : https://wiki.corp.adobe.com/pages/viewpage.action?pageId=3330887979

cc: @skambi

skumar09

@sharmrj : Could you please also update the locators for Nala Feds tests,
features/feds/footer/footer.test, as tests are failing

cc: @sigadamvenkata @narcis-radu @mokimo

…-standalone-gnav

github-actions · 2024-11-13T01:26:13Z

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

…-standalone-gnav

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/chunk-Z64B4EXQ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/chunk-ZEVYWJU7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/delayed-CEINYTGH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/dropdown-TP2KXQKZ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/dynamic-navigation-3LHZLN6G.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/federated-UVUTNMCQ.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/footer-promo-RO3LMJQB.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/fragment-WO6WLZWW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/georouting-KUIR5VC4.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/georoutingv2-L24H7P4L.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/global-footer-RKXQBHDV.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/global-navigation-UWTEC37Q.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/gnav-search-CZSWEN73.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/image-video-link-BXT53NYU.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/japanese-word-wrap-YO7MCKS2.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/keyboard-S6OXUVVP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/locales-PE6ERXTI.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/logWebVitals-NC52TIG5.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/martech-WZTIIXGW.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/martech-metadata-T7F4QCM7.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/menu-KIKFNGJK.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/modal-JZCKO3U4.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/modal.merch-ILIM5VBD.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/personalization-DCXT7K44.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/placeholders-HRFGGIOR.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/preview-Z4GLPTFU.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/promo-utils-7ZAMIX3W.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/region-nav-XIO725PL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/richresults-GAU5FOJP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/samplerum-UMPZCNEM.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/send-to-caas-LGEZRSDO.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/seotech-UFKMTZPX.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/sidekick-QZNX6CDT.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/sidekick-decorate-DJSQ7GPH.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/status-CKLF3XKF.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/title-append-2CWER3AB.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/utils-IERWOBZX.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/8d786a0347c184ee3d3dde405710c645fcad1a4b/libs/navigation/dist/webapp-prompt-D4XVB3ZL.js

github-actions · 2024-11-14T06:48:34Z

libs/navigation/dist/aside-3A4QYQCL.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:35Z

libs/navigation/dist/attributes-JBNSX35B.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:36Z

libs/navigation/dist/bootstrapper-OPTZNGC6.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:36Z

libs/navigation/dist/breadcrumbs-TABD6U2G.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:37Z

libs/navigation/dist/chunk-CVDLXPU4.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:38Z

libs/navigation/dist/chunk-EI44K5W3.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:39Z

libs/navigation/dist/chunk-HCLINCID.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:40Z

libs/navigation/dist/chunk-I4EBDGNP.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:41Z

libs/navigation/dist/chunk-LHF7GOQG.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-11-14T06:48:42Z

libs/navigation/dist/chunk-XZJABLST.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

libs/navigation/dist/chunk-ZEVYWJU7.js

sharmrj added 4 commits November 3, 2024 15:02

bundled standalone gnav and footer

da2a5eb

Fixed dark mode; load css from navigation.js

534324c

Refactored global footer to no longer use milo modal to render region…

0afaceb

…-nav

global footer unit test

e940057

sharmrj requested review from salonijain3, bandana147, nishantka, Deva309 and sonawanesnehal3 as code owners November 4, 2024 04:43

sharmrj mentioned this pull request Nov 4, 2024

MWPW-161273 Standalone Gnav needs a release cycle #3113

Closed

github-actions bot reviewed Nov 4, 2024

View reviewed changes

fix lint

f251eca

aem-code-sync bot temporarily deployed to bundled-standalone-gnav November 4, 2024 04:48 Inactive

github-actions bot reviewed Nov 4, 2024

View reviewed changes

sharmrj added 2 commits November 4, 2024 11:41

Added keyboard navigation to the new region nav modal

acf1172

export stuff from modal.js

e38db1a

aem-code-sync bot temporarily deployed to bundled-standalone-gnav November 4, 2024 06:12 Inactive

github-actions bot reviewed Nov 4, 2024

View reviewed changes

spadmasa assigned spadmasa and prativas22 Nov 4, 2024

mokimo approved these changes Nov 4, 2024

View reviewed changes

sharmrj added 2 commits November 5, 2024 08:33

Merge branch 'stage' of https://github.com/adobecom/milo into bundled…

c3a47fa

…-standalone-gnav

replaced the new modal implementation with a more explicit usage of t…

bdb4d5c

…he current milo modal so that it can be bundled

github-actions bot reviewed Nov 5, 2024

View reviewed changes

code compatibility ignore pattern

4ac107c

aem-code-sync bot temporarily deployed to bundled-standalone-gnav November 5, 2024 03:48 Inactive

aem-code-sync bot temporarily deployed to bundled-standalone-gnav November 5, 2024 06:13 Inactive

github-actions bot reviewed Nov 5, 2024

View reviewed changes

skumar09 self-requested a review November 5, 2024 15:04

skumar09 requested changes Nov 5, 2024

View reviewed changes

Merge branch 'stage' of https://github.com/adobecom/milo into bundled…

2330b70

…-standalone-gnav

github-actions bot added the Stale label Nov 13, 2024

sharmrj added 2 commits November 14, 2024 12:06

Merge branch 'stage' of https://github.com/adobecom/milo into bundled…

3265617

…-standalone-gnav

built latest gnav changes

8d786a0

github-actions bot reviewed Nov 14, 2024

View reviewed changes

github-advanced-security bot found potential problems Nov 14, 2024

View reviewed changes

libs/navigation/dist/chunk-ZEVYWJU7.js Dismissed Show dismissed Hide dismissed

github-actions bot removed the Stale label Nov 15, 2024

amitbikram approved these changes Nov 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-161273 Standalone Gnav needs a release cycle [Bundle] #3132

MWPW-161273 Standalone Gnav needs a release cycle [Bundle] #3132

sharmrj commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

github-actions bot left a comment

codecov bot commented Nov 4, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

mokimo left a comment

mokimo Nov 4, 2024

mokimo Nov 4, 2024

sharmrj Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

github-actions bot Nov 5, 2024

salonijain3 commented Nov 5, 2024

skumar09 left a comment

github-actions bot commented Nov 13, 2024

github-actions bot left a comment

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

		@@ -0,0 +1,20 @@
		import * as esbuild from 'esbuild'; // eslint-disable-line

MWPW-161273 Standalone Gnav needs a release cycle [Bundle] #3132

Are you sure you want to change the base?

MWPW-161273 Standalone Gnav needs a release cycle [Bundle] #3132

Conversation

sharmrj commented Nov 4, 2024 • edited Loading

aem-code-sync bot commented Nov 4, 2024 • edited Loading

aem-code-sync bot commented Nov 4, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 4, 2024 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

mokimo left a comment

Choose a reason for hiding this comment

mokimo Nov 4, 2024

Choose a reason for hiding this comment

mokimo Nov 4, 2024

Choose a reason for hiding this comment

sharmrj Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

github-actions bot Nov 5, 2024

Choose a reason for hiding this comment

salonijain3 commented Nov 5, 2024

skumar09 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 13, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

sharmrj commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

aem-code-sync bot commented Nov 4, 2024 •

edited

Loading

codecov bot commented Nov 4, 2024 •

edited

Loading

sharmrj Nov 5, 2024 •

edited

Loading