Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual floating cta #1244

Merged
merged 28 commits into from
Nov 14, 2024
Merged

Dual floating cta #1244

merged 28 commits into from
Nov 14, 2024
+210 −3

Conversation

echen-adobe
Copy link
Collaborator

@echen-adobe echen-adobe commented Oct 29, 2024 •
edited
Loading

Fixes following issues|Adds following features:

  • Issue/Feature 1
  • Implements dual action floating CTA for mobile devices.

Resolves: https://jira.corp.adobe.com/projects/MWPW/issues/MWPW-160440

Steps to test the before vs. after and expectations:

  • Steps for feature 1
    1. Test for Android + low RAM gating
      Use browerstack to visit the page below using a Galaxy S5 Mini. Verify that the dual action CTA does not show up on this device.
    1. Test regular devices
      Visit the url on desktop + iPhone to ensure you only get the regular floating CTA.
    1. Test Android
  • Use browerstack to visit the page below using a Pixel phone or anything else w/ 4GB or more Ram. Verify that the dual action CTA shows up

Pages to check for regression and performance:

Screenshot 2024-10-30 at 1 46 36 PM

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 29, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@echen-adobe echen-adobe marked this pull request as draft October 29, 2024 21:46
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 30, 2024 •
edited
Loading

Page Scores Audits
📱 /drafts/echen/pricing-cards-simplified PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /drafts/echen/pricing-cards-simplified PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@echen-adobe echen-adobe marked this pull request as ready for review October 30, 2024 20:47
JingleH
JingleH requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@JingleH JingleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few remaining lint issues too

express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
fullcolorcoder
fullcolorcoder previously requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@fullcolorcoder fullcolorcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Few var usages need refinement
  • Curious about an unresolved comment regarding authoring metadata missing

express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
express/blocks/mobile-gating-button/mobile-gating-button.css Outdated Show resolved Hide resolved
@echen-adobe echen-adobe dismissed fullcolorcoder’s stale review November 14, 2024 17:24

OOO, changed colors to variables, need to get this merged this week.

@echen-adobe
Squashed commit of the following:
109c91b 
commit 8a687a4
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 15:04:07 2024 -0800

    ...

commit 1304721
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 14:58:32 2024 -0800

    lint

commit 2bc81f6
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 14:31:39 2024 -0800

    lint

commit 2d556fd
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 14:28:47 2024 -0800

    Update mobile-fork-button.js

commit 48a737d
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 14:26:26 2024 -0800

    Update mobile-fork-button.js

commit 2c019ea
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 10:30:47 2024 -0800

    ...

commit d1a2cbc
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 10:18:38 2024 -0800

    Update mobile-gating-button.js

commit 29859d4
Author: echen-adobe <[email protected]>
Date:   Wed Nov 13 10:18:29 2024 -0800

    Update mobile-gating-button.js
@echen-adobe echen-adobe merged commit 19b8aa9 into stage Nov 14, 2024
6 checks passed
@JingleH JingleH mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullcolorcoder fullcolorcoder fullcolorcoder left review comments

@jsandland jsandland jsandland approved these changes

@JingleH JingleH JingleH approved these changes

@kennethlum kennethlum Awaiting requested review from kennethlum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@echen-adobe @fullcolorcoder @JingleH @jsandland