Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive marquee optimization #1135

Open
wants to merge 18 commits into
base: stage
Choose a base branch
from

Conversation

echen-adobe
Copy link
Collaborator

@echen-adobe echen-adobe commented Sep 13, 2024

Fixes following issues|Adds following features:

  • Issue/Feature 1
    Improves the performance of the Interactive Marquee by stripping out unnecessary imports.

Resolves: https://jira.corp.adobe.com/browse/MWPW-154591

Steps to test the before vs. after and expectations:

  • Steps for feature 1
  • Visit the branch link below and verify that everything is close to the design, the hover on the cards works and the generate link works.
  • Verify the page looks close to the design on mobile as well.

https://www.figma.com/proto/DZa36dkOpGcjF9j9udvAoq/AX0195---AI-SEO-pages?page-id=1283%3A13582&node-id=1326-23649&viewport=2912%2C728%2C0.22&t=aCVNR6M3lHRCeXFK-1&scaling=min-zoom&content-scaling=fixed

Screenshot 2024-09-13 at 2 30 40 PM

Pages to check for regression and performance:

Performance Comparision
Screenshot 2024-09-16 at 10 04 58 AM
Screenshot 2024-09-16 at 10 05 01 AM

https://www.webpagetest.org/result/240916_BiDc45_9VB/
https://www.webpagetest.org/result/240916_BiDc63_9VA/

Copy link

aem-code-sync bot commented Sep 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 13, 2024

@aem-code-sync aem-code-sync bot temporarily deployed to interactive-marquee-optimization September 16, 2024 17:01 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to interactive-marquee-optimization September 16, 2024 17:12 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to interactive-marquee-optimization September 16, 2024 17:22 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to interactive-marquee-optimization September 16, 2024 17:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to interactive-marquee-optimization September 18, 2024 21:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant