Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cta-carousel block #73

Merged
merged 5 commits into from
Oct 18, 2024
Merged

add cta-carousel block #73

merged 5 commits into from
Oct 18, 2024

Conversation

jrrings
Copy link
Contributor

@jrrings jrrings commented Oct 14, 2024

Describe your specific features or fixes

Resolves: MWPW-143347

Test URLs:

Copy link

aem-code-sync bot commented Oct 14, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 84.93151% with 44 lines in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (8f281e1) to head (5504734).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
express/blocks/cta-carousel/cta-carousel.js 85.49% 38 Missing ⚠️
express/scripts/utils.js 80.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   63.76%   66.88%   +3.11%     
==========================================
  Files          45       48       +3     
  Lines        6725     7443     +718     
==========================================
+ Hits         4288     4978     +690     
- Misses       2437     2465      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fullcolorcoder fullcolorcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I hover over an element, the hover text that appears below needs to be more to the right.
image

when I furthermore go to https://mwpw-143347--express-milo--adobecom.hlx.live/express/entitled/designer , fill in a prompt text and try to generate an image, the prompt text is not being passed to new.express.adobe.com

Copy link

aem-code-sync bot commented Oct 17, 2024

Page Scores Audits
📱 /express/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

express/scripts/utils.js Dismissed Show dismissed Hide dismissed
express/scripts/utils.js Dismissed Show dismissed Hide dismissed
express/scripts/utils.js Dismissed Show dismissed Hide dismissed
express/scripts/utils.js Dismissed Show dismissed Hide dismissed
express/scripts/utils.js Fixed Show fixed Hide fixed
express/scripts/utils.js Fixed Show fixed Hide fixed
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@jrrings jrrings merged commit c9783a1 into main Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants