Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quick-action-hub #72

Merged
merged 2 commits into from
Oct 17, 2024
Merged

add quick-action-hub #72

merged 2 commits into from
Oct 17, 2024

Conversation

jrrings
Copy link
Contributor

@jrrings jrrings commented Oct 10, 2024

Copy link

aem-code-sync bot commented Oct 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 10, 2024

Page Scores Audits
📱 /express/feature PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/feature PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 13.33333% with 52 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (51241ff) to head (1eb69af).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...xpress/blocks/quick-action-hub/quick-action-hub.js 13.33% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   64.94%   64.57%   -0.37%     
==========================================
  Files          38       42       +4     
  Lines        5611     6459     +848     
==========================================
+ Hits         3644     4171     +527     
- Misses       1967     2288     +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fullcolorcoder fullcolorcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Everything is working and looks nice, but I do see a padding difference in the wrapper.

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good, but the styling on mobile is different.

@jrrings jrrings merged commit ec764e3 into main Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants