Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icon-list block #70

Merged
merged 4 commits into from
Oct 18, 2024
Merged

add icon-list block #70

merged 4 commits into from
Oct 18, 2024

Conversation

jrrings
Copy link
Contributor

@jrrings jrrings commented Oct 8, 2024

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 8, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 8, 2024 •
edited
Loading

Page Scores Audits
📱 /de/express/create/video/marketing PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /de/express/create/video/marketing PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
📱 /express/create/video/advertisement PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/create/video/advertisement PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
📱 /express/nonprofits PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/nonprofits PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

fullcolorcoder
fullcolorcoder requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@fullcolorcoder fullcolorcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Main thing here is style not getting picked up to wrap the list and make the grid look nice

vhargrave
vhargrave requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/linters seem to be failing + the p text seems to be too big on mobile

https://mwpw-143368--express-milo--adobecom.hlx.page/de/express/create/video/marketing
image
image

@jrrings jrrings merged commit 4cacdf2 into main Oct 18, 2024
4 of 6 checks passed
@vhargrave vhargrave deleted the MWPW-143368 branch October 21, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullcolorcoder fullcolorcoder Awaiting requested review from fullcolorcoder

@vhargrave vhargrave Awaiting requested review from vhargrave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrrings @fullcolorcoder @vhargrave