[MWPW-143407] Search Marquee And Content Replace

[echen-adobe]

Adds the search marquee block into Milo.

Requires the injection of a content-replacer script into our scripts.js however. The existing pages are authored with {{ }} tokens that are filled with content from metadata sheets. Milo however removes these {{ }} tokens and does its own replacement.

At the moment, there is no easy way to get around the widespread usage of {{ }} tokens in our pages except to run our own token replacement logic before Milo does. Open to better solutions.

Also working on using the correct fetchPlaceholders, the one that is currently on Milo does not seem to work

After:
https://search-marquee--express-milo--adobecom.hlx.page/express/templates/?milolibs=local

miloLibs must be set to local and a local milo instance must be running due to an issue with placeholders. This should be resolved after Mobile GA when we can change our placeholders file to be compatible with Milo

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• dc6f834 ✅ (latest)
• f962a5e ✅
• eed6e35 ✅
• 6355a2d ✅
• d5b30d2 ✅
• d12e940 ✅
• c31f062 ✅
• 259f847 ✅
• 331e7b7 ✅
• b18e758 ✅
• 651e92d ✅
• f3a6150 ✅
• 958797e ✅
• 8fe31d8 ✅
• dfc18e8 ✅
• 352cb09 ✅
• 5afbb0a ✅
• a802a03 ✅
• 3021c55 ✅
• 99369a8 ✅
• 7432d07 ✅
• d42356c ✅
• a0ef2ab ✅
• d586acd ✅
• 661e37f ✅
• 5a836c2 ✅
• 966f62d ❌
• a767fd9 ❌
• 483766d ❌
• 048a4a2 ❌

[vhargrave]

Just a few more notes :)

1. why not just change our template default pages to use [[]] instead of {{}}? That seems like a day of effort and then we don't have this problem anymore. We'd have to work with Ernest for this, but that's the whole point of these tasks right.
2. I saw your notes regarding the placeholders not working. You can get them to work pretty easily by overriding a piece of the milo placeholder code to accept Text as column value as well. I can show you how that works. Just send me a ping.

[echen-adobe]

Just a few more notes :)

1. why not just change our template default pages to use [[]] instead of {{}}? That seems like a day of effort and then we don't have this problem anymore. We'd have to work with Ernest for this, but that's the whole point of these tasks right.

I think a lot of issues with this PR revolve around this. From what I understand, replacing all the {{}} tokens with [[]] is a non trivial task, which is why I went with content-replace. Content replace also includes {{ }} usage logic itself, such as replacing tokens with metadata, so it is not as simple as replacing all {{ }} with [[]] throughout the docs, many pages will need the {{}} logic distributed to them.

I think it will be possible to map all the pages that do require the {{ }} token efficiently if a script of mine works out, but we will still need to figure out how to distribute the replacement logic within content.js

[vhargrave]

Just a few more notes :)

1. why not just change our template default pages to use [[]] instead of {{}}? That seems like a day of effort and then we don't have this problem anymore. We'd have to work with Ernest for this, but that's the whole point of these tasks right.

I think a lot of issues with this PR revolve around this. From what I understand, replacing all the {{}} tokens with [[]] is a non trivial task, which is why I went with content-replace. Content replace also includes {{ }} usage logic itself, such as replacing tokens with metadata, so it is not as simple as replacing all {{ }} with [[]] throughout the docs, many pages will need the {{}} logic distributed to them.

I think it will be possible to map all the pages that do require the {{ }} token efficiently if a script of mine works out, but we will still need to figure out how to distribute the replacement logic within content.js

we probably only want it to run on the template-x block & colors block right?
So I would select for them. For all other blocks I expect {{}} to only contain placeholders.

[echen-adobe]

Just a few more notes :)

1. why not just change our template default pages to use [[]] instead of {{}}? That seems like a day of effort and then we don't have this problem anymore. We'd have to work with Ernest for this, but that's the whole point of these tasks right.

I think a lot of issues with this PR revolve around this. From what I understand, replacing all the {{}} tokens with [[]] is a non trivial task, which is why I went with content-replace. Content replace also includes {{ }} usage logic itself, such as replacing tokens with metadata, so it is not as simple as replacing all {{ }} with [[]] throughout the docs, many pages will need the {{}} logic distributed to them.
I think it will be possible to map all the pages that do require the {{ }} token efficiently if a script of mine works out, but we will still need to figure out how to distribute the replacement logic within content.js

we probably only want it to run on the template-x block & colors block right? So I would select for them. For all other blocks I expect {{}} to only contain placeholders.

I know that it is used in the marquee and pricing cards blocks to substitute information based on locales, its likely present elsewhere.

[vhargrave]

looking better and better mate!

[vhargrave]

This is a clean approach, but I need the most performant approach possible.
That means instead of importing and delaying the whole page load by another 100-200 milliseconds just add the code from autoUpdateContent that you really really need even if it's copy pasted. Don't add the whole file if possible. Just the code that you really need executed here.

[aem-code-sync]

Page	Scores	Audits
/express/templates/?milolibs=local