Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collapsible-card block #67

Merged
merged 2 commits into from
Oct 17, 2024
Merged

add collapsible-card block #67

merged 2 commits into from
Oct 17, 2024

Conversation

Copy link

aem-code-sync bot commented Oct 7, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 7, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.87%. Comparing base (51241ff) to head (9901ba7).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...xpress/blocks/collapsible-card/collapsible-card.js 95.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   64.94%   64.87%   -0.08%     
==========================================
  Files          38       43       +5     
  Lines        5611     6499     +888     
==========================================
+ Hits         3644     4216     +572     
- Misses       1967     2283     +316     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. Just found one small code thing, and once you've done that you can go ahead and merge imo.

express/scripts/utils/os.js Outdated Show resolved Hide resolved
@vhargrave vhargrave merged commit afe797f into main Oct 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants