Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marquee migration #59

Merged
merged 9 commits into from
Sep 30, 2024
Merged

marquee migration #59

merged 9 commits into from
Sep 30, 2024

Conversation

vhargrave
Copy link
Collaborator

@vhargrave vhargrave commented Sep 25, 2024

Copy link

aem-code-sync bot commented Sep 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 74.08638% with 156 lines in your changes missing coverage. Please review.

Project coverage is 65.36%. Comparing base (ef6711d) to head (e5760e9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
express/blocks/ax-marquee/ax-marquee.js 76.35% 131 Missing ⚠️
express/scripts/utils.js 26.08% 17 Missing ⚠️
express/scripts/utils/location-utils.js 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   64.52%   65.36%   +0.84%     
==========================================
  Files          39       41       +2     
  Lines        6001     6396     +395     
==========================================
+ Hits         3872     4181     +309     
- Misses       2129     2215      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fullcolorcoder fullcolorcoder merged commit 4cf152e into main Sep 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants