Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pricing-table block #57

Merged
merged 4 commits into from
Oct 7, 2024
Merged

add pricing-table block #57

merged 4 commits into from
Oct 7, 2024

Conversation

Copy link

aem-code-sync bot commented Sep 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 16, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.22%. Comparing base (51241ff) to head (76c5a5c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   64.94%   65.22%   +0.28%     
==========================================
  Files          38       41       +3     
  Lines        5611     6399     +788     
==========================================
+ Hits         3644     4174     +530     
- Misses       1967     2225     +258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fullcolorcoder fullcolorcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Just a few small things I notice:

  • Font weight difference in Compare Features
  • Button decoration and "Free" alignment on desktop
  • Mobile differences - button appearing in table where it doesn't on prod

@jrrings jrrings merged commit 9a80bc6 into main Oct 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants