MWPW-158182 listen to milo events and activate google yolo #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 54.54% 59.65% +5.10%
==========================================
Files 40 39 -1
Lines 6435 5953 -482
==========================================
+ Hits 3510 3551 +41
+ Misses 2925 2402 -523 ☔ View full report in Codecov by Sentry. |
| import('./google-yolo.js').then((mod) => { | ||
| mod.default(); | ||
| }); | ||
| // import('./google-yolo.js').then((mod) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add events for google yolo
Resolves: MWPW-158182
Test URLs:
I've also added a milo branch with the events. Unfortauntely we're getting CORS errors for ims that still need to be fixed, but it would theoretically work here
https://mwpw-158182-google-yolo--express-milo--adobecom.hlx.page/express/colors/gunmetal?milolibs=vhargrave-MWPW-142878-events