Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Toggle Bar Block #55

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Migrate Toggle Bar Block #55

merged 9 commits into from
Sep 23, 2024

Conversation

jrrings
Copy link
Contributor

@jrrings jrrings commented Sep 12, 2024

Copy link

aem-code-sync bot commented Sep 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@jrrings jrrings changed the title Mwpw 143411 Migrate Toggle Bar Block Sep 12, 2024
Copy link

aem-code-sync bot commented Sep 12, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.82022% with 11 lines in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (1d6d4d6) to head (3da3bf8).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
express/blocks/toggle-bar/toggle-bar.js 93.82% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #55       +/-   ##
===========================================
+ Coverage   54.54%   64.81%   +10.26%     
===========================================
  Files          40       39        -1     
  Lines        6435     6036      -399     
===========================================
+ Hits         3510     3912      +402     
+ Misses       2925     2124      -801     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@vhargrave vhargrave merged commit 51c1a74 into main Sep 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants