Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync repos #54

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Sync repos #54

merged 7 commits into from
Sep 5, 2024

Conversation

vhargrave
Copy link
Collaborator

@vhargrave vhargrave commented Sep 5, 2024

sync repos

Test URLs:

interactive-marquee (variable for line heights is a little different now, so there will be more space between lines)

how to cards

logo row

pricing cards credits

quick action page

create page

templates

blog

Copy link

aem-code-sync bot commented Sep 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@jrrings
Copy link
Collaborator

jrrings commented Sep 5, 2024

@vhargrave - Code looks good to me and the link I spot checked seem to all be working fine. The tests are failing in the PR, but they run fine locally for me.

@vhargrave vhargrave merged commit 9f966ee into main Sep 5, 2024
5 of 6 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.75099% with 148 lines in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (bbdcc0b) to head (185b7ee).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
express/blocks/ax-columns/ax-columns.js 8.51% 43 Missing ⚠️
express/blocks/template-x/template-rendering.js 5.71% 33 Missing ⚠️
express/scripts/widgets/video.js 0.00% 29 Missing ⚠️
.../blocks/interactive-marquee/interactive-marquee.js 87.28% 22 Missing ⚠️
express/scripts/utils/pricing.js 41.66% 7 Missing ⚠️
express/blocks/how-to-cards/how-to-cards.js 96.98% 5 Missing ⚠️
express/scripts/widgets/floating-cta.js 50.00% 3 Missing ⚠️
express/blocks/template-x/template-x.js 0.00% 2 Missing ⚠️
express/template-x/template-search-api-v3.js 0.00% 2 Missing ⚠️
express/scripts/utils.js 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   37.26%   38.76%   +1.50%     
==========================================
  Files          39       45       +6     
  Lines        8819     9756     +937     
==========================================
+ Hits         3286     3782     +496     
- Misses       5533     5974     +441     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants