Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fragment block #53

Merged
merged 6 commits into from
Sep 11, 2024
Merged

feat: add fragment block #53

merged 6 commits into from
Sep 11, 2024

Conversation

jrrings
Copy link
Contributor

@jrrings jrrings commented Aug 30, 2024

Describe your specific features or fixes

Resolves: MWPW-143358

Test URLs:

Copy link

aem-code-sync bot commented Aug 30, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 30, 2024

Page Scores Audits
M /express/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
D /express/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking pretty good!
just saw two tiny things to fix and then we should be golden :)

express/styles/styles.css Outdated Show resolved Hide resolved
express/scripts/utils.js Outdated Show resolved Hide resolved
@jrrings jrrings changed the title Mwpw 143358 feat: add fragment block Sep 3, 2024
Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might have resolved the things I wrote, but not pushed your code @jrrings ?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (185b7ee) to head (7da2e01).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
express/scripts/utils.js 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   38.76%   41.13%   +2.36%     
==========================================
  Files          45       43       -2     
  Lines        9756     8985     -771     
==========================================
- Hits         3782     3696      -86     
+ Misses       5974     5289     -685     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vhargrave vhargrave merged commit 64c2b75 into main Sep 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants