Template X #45
Template X #45
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
There's a lot that's great here, and the block is looking pretty good.
Obviously with a block/blocks like this I found a couple of things.
- There needs to be more distance between the seo-nav and the long-text on desktop
- same for the distance between the seo-nav and the template-x block
- placeholders like hero title are not replaced at all on the JP pages - https://template-x--express-milo--adobecom.hlx.live/jp/express/templates/?martech=off
- Some templates are too large now, see this page vs the live page as an example -https://template-x--express-milo--adobecom.hlx.live/uk/express/fragments/index-featured-templates
- I noticed on this page - https://template-x--express-milo--adobecom.hlx.live/express/create/story/instagram, that if I set the width of my screen to 700px that the content doesn't look right.
- I took a look at using the placeholders from milo and think I got it working. Curious what you also think - use placeholders from milo #46 . I didn't find any place where I needed the whole list of placeholders tbh, so it's possible I missed something.
use placeholders from milo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
===========================================
- Coverage 58.30% 37.91% -20.40%
===========================================
Files 23 41 +18
Lines 3816 8855 +5039
===========================================
+ Hits 2225 3357 +1132
- Misses 1591 5498 +3907 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Found a few more things unfortunately on top of things that I've already pinged.
When on this page https://template-x--express-milo--adobecom.hlx.live/de/express/templates/?martech=off I noticed:
- when clicking on the search field, it's automatically showing me search results in English. On the live page it doesn't show anything
- when clicking on the search field, there are no green check marks for "Kostenlos nutzen"
- The text right above the search field is not perfectly centered. It's somehow leaning slightly to the left on desktop
- Right above the template-x block (on the left hand side), I should be seeing breadcrumbs. Now they're gone.
- I'm seeing a null still in the content of the seo-nav block
- The distance between the seo-nav block and the long-text block is still too little.
On this page https://template-x--express-milo--adobecom.hlx.live/uk/express/fragments/index-featured-templates
- the templates are still too large sometimes. If you compare with the live page you'll see it.
https://template-x--express-milo--adobecom.hlx.live/express/create/story/instagram
- same comment as before. If you set the screen size to 700px it doesn't look the same as production. I don't mind your version actually, but if we change we should at least clarify with Mariah
fullcolorcoder
dismissed
vhargrave’s stale review
carrying to general fixes ticket
Migration of Template X block, along with some companion blocks.
Resolves:
MWPW-143409 - template x
MWPW-143332 - browse by category
MWPW-143376 - long text
MWPW-143398 - search marquee
MWPW-143399 - seo nav
Test URLs: