Template X

[fullcolorcoder]

Migration of Template X block, along with some companion blocks.

Resolves:
MWPW-143409 - template x
MWPW-143332 - browse by category
MWPW-143376 - long text
MWPW-143398 - search marquee
MWPW-143399 - seo nav

Test URLs:

• Pre Migration Link: https://adobe.com/express/
• Before: https://main--express-milo--adobecom.hlx.page/express/templates/
• After: https://template-x--express-milo--adobecom.hlx.page/express/templates/?martech=off

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 274cb6f ✅ (latest)
• bfffcad ✅
• 8aa9b48 ✅
• b335958 ✅
• 8a113a8 ✅
• 776c124 ✅
• ca48d09 ✅
• 0e8a251 ✅
• cc544ab ✅
• 182fcdb ✅
• e487e81 ✅
• 3ca11a3 ✅
• 7bf62bf ✅
• 5cd5cd2 ✅
• c1c3234 ✅
• a810d40 ✅
• 76568b2 ✅
• cbe1e60 ✅
• 12427ad ✅
• 12b2800 ✅

[aem-code-sync]

	Page	Scores	Audits
M	/express/templates/?martech=off
D	/express/templates/?martech=off

[vhargrave]

There's a lot that's great here, and the block is looking pretty good.
Obviously with a block/blocks like this I found a couple of things.

1. There needs to be more distance between the seo-nav and the long-text on desktop
2. same for the distance between the seo-nav and the template-x block
3. placeholders like hero title are not replaced at all on the JP pages - https://template-x--express-milo--adobecom.hlx.live/jp/express/templates/?martech=off
4. Some templates are too large now, see this page vs the live page as an example -https://template-x--express-milo--adobecom.hlx.live/uk/express/fragments/index-featured-templates
5. I noticed on this page - https://template-x--express-milo--adobecom.hlx.live/express/create/story/instagram, that if I set the width of my screen to 700px that the content doesn't look right.
6. I took a look at using the placeholders from milo and think I got it working. Curious what you also think - use placeholders from milo #46 . I didn't find any place where I needed the whole list of placeholders tbh, so it's possible I missed something.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 8.54123% with 2163 lines in your changes missing coverage. Please review.

Project coverage is 37.91%. Comparing base (bc26bcf) to head (b335958).
Report is 15 commits behind head on main.

Files	Patch %	Lines
express/blocks/template-x/template-x.js	4.42%	1684 Missing ⚠️
express/blocks/template-x/template-rendering.js	6.75%	442 Missing ⚠️
express/scripts/color-tools.js	4.00%	24 Missing ⚠️
express/blocks/search-marquee/search-marquee.js	12.50%	7 Missing ⚠️
express/blocks/long-text/long-text.js	89.47%	2 Missing ⚠️
express/blocks/seo-nav/seo-nav.js	96.22%	2 Missing ⚠️
express/scripts/utils.js	80.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   58.30%   37.91%   -20.40%     
===========================================
  Files          23       41       +18     
  Lines        3816     8855     +5039     
===========================================
+ Hits         2225     3357     +1132     
- Misses       1591     5498     +3907     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vhargrave]

Found a few more things unfortunately on top of things that I've already pinged.

When on this page https://template-x--express-milo--adobecom.hlx.live/de/express/templates/?martech=off I noticed:

1. when clicking on the search field, it's automatically showing me search results in English. On the live page it doesn't show anything
2. when clicking on the search field, there are no green check marks for "Kostenlos nutzen"
3. The text right above the search field is not perfectly centered. It's somehow leaning slightly to the left on desktop
4. Right above the template-x block (on the left hand side), I should be seeing breadcrumbs. Now they're gone.
5. I'm seeing a null still in the content of the seo-nav block
6. The distance between the seo-nav block and the long-text block is still too little.

On this page https://template-x--express-milo--adobecom.hlx.live/uk/express/fragments/index-featured-templates

1. the templates are still too large sometimes. If you compare with the live page you'll see it.

https://template-x--express-milo--adobecom.hlx.live/express/create/story/instagram

1. same comment as before. If you set the screen size to 700px it doesn't look the same as production. I don't mind your version actually, but if we change we should at least clarify with Mariah

carrying to general fixes ticket