Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154535 fix padding columns #44

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

vhargrave
Copy link
Collaborator

Fix issues reported during testing.

Resolves: MWPW-154535

Test URLs:
Padding under the columns centered wasn't quite right
Before: https://main--express-milo--adobecom.hlx.page/express/
After: https://mwpw-154535-fixes-sprint6--express-milo--adobecom.hlx.live/kr/express/create/advertisement

The issue that was reported here was that images on the blog pages were aligned left, but these issues were all fixed with the work on blog.
Before: https://main--express-milo--adobecom.hlx.page/express/learn/blog/social-media-branding-strategy
After: https://mwpw-154535-fixes-sprint6--express-milo--adobecom.hlx.page/express/learn/blog/social-media-branding-strategy

Copy link

aem-code-sync bot commented Aug 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 12, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.21%. Comparing base (ce00c46) to head (32e3fdc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   58.21%   58.21%           
=======================================
  Files          23       23           
  Lines        3769     3769           
=======================================
  Hits         2194     2194           
  Misses       1575     1575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vhargrave vhargrave merged commit bc26bcf into main Aug 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants