Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MWPW-143356 | add floating-button block #39

Closed
wants to merge 1 commit into from
Closed

Conversation

jrrings
Copy link
Collaborator

@jrrings jrrings commented Jul 26, 2024

Describe your specific features or fixes

Adding the floating button block

The floating button only seems to be utilized on desktop. For mobile scenarios, it looks like the multifunction-button is used. So when testing on mobile, you should not expect to see a floating button.

Resolves: MWPW-143356

Test URLs:

Additional Testing URLs:

Copy link

aem-code-sync bot commented Jul 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 26, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.22727% with 526 lines in your changes missing coverage. Please review.

Project coverage is 56.92%. Comparing base (5b9c2b7) to head (45dbdeb).
Report is 14 commits behind head on main.

Files Patch % Lines
express/scripts/utils/pricing.js 32.25% 271 Missing ⚠️
express/scripts/widgets/floating-cta.js 44.13% 238 Missing ⚠️
express/scripts/utils.js 10.52% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   57.22%   56.92%   -0.31%     
==========================================
  Files          22       26       +4     
  Lines        3521     4550    +1029     
==========================================
+ Hits         2015     2590     +575     
- Misses       1506     1960     +454     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrrings jrrings closed this Jul 26, 2024
@jrrings jrrings deleted the MWPW-143356 branch July 26, 2024 18:48
@jrrings
Copy link
Collaborator Author

jrrings commented Jul 26, 2024

replaced by: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants