Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mwpw 150493 fixessprint4 #35

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Mwpw 150493 fixessprint4 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a783cfe
MWPW-150493 fix image list & steps
vhargrave Jul 3, 2024
6ddee15
MWPW-150493 fix banner text margins
vhargrave Jul 4, 2024
a2c1bf6
MWPW-150493 fix linters
vhargrave Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions express/blocks/banner/banner.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
text-align: center;
}

.banner p {
margin: 32px 0;
}

.banner h1,
.banner h2,
.banner h3,
Expand Down
26 changes: 13 additions & 13 deletions express/blocks/image-list/image-list.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
.image-list img {
width: 300px;
margin: 12.5px;
}
}

.image-list .mobile-only {
display: block;
Expand All @@ -33,23 +33,23 @@
}
.image-list.xl img {
width: 810px;
}
}

.image-list.l img {
margin: 15px;
width: 375px;
}

.image-list img {
margin: 15px;
width: 240px;
}

.image-list.s img {
margin: 11px;
width: 180px;
}

.image-list.xs img {
margin: 11px;
width: 140px;
Expand All @@ -58,31 +58,31 @@
}

@media (min-width: 1200px) {

.image-list {
margin: 60px;
margin: 60px auto;
}

.image-list.xl img {
margin: 0;
width: 1080px;
}
}

.image-list.l img {
margin: 20px;
width: 500px;
}

.image-list img {
margin: 15px;
width: 330px;
}

.image-list.s img {
margin: 15px;
width: 240px;
}

.image-list.xs img {
margin: 14px;
width: 188px;
Expand Down
2 changes: 1 addition & 1 deletion express/blocks/steps/steps.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
margin-right: 20px;
}

.steps .step-image picture img,
.steps .step-image svg,
.steps .step-image img.icon {
width: 40px;
max-width: unset;
Expand Down
2 changes: 2 additions & 0 deletions express/blocks/steps/steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { getLibs } from '../../scripts/utils.js';
import { fixIcons } from '../../scripts/utils/icons.js';

const { createTag } = await import(`${getLibs()}/utils/utils.js`);

Expand All @@ -13,6 +14,7 @@ export function addBlockClasses(block, classNames) {

export default async function decorate(block) {
addBlockClasses(block, ['step-image', 'step-description']);
fixIcons(block);

const section = block.closest('.section');
const heading = section.querySelector('h2, h3, h4');
Expand Down
3 changes: 2 additions & 1 deletion express/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ header #feds-header a.feds-navLink:hover .feds-navLink-text {
/* buttons */
a.button:any-link {
text-decoration: none;
border-radius: 999px;
border-radius: 18px;
padding: 5px 1.2em 6px;
text-align: center;
font-size: var(--body-font-size-s);
Expand Down Expand Up @@ -190,6 +190,7 @@ a.con-button:any-link {
overflow: hidden;
text-overflow: ellipsis;
display: inline-block;
min-height: initial;
}

svg.icon-milo, img.icon-milo {
Expand Down
Loading