Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-143405: table-of-contents block #20

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Conversation

rl-adobe
Copy link
Contributor

@rl-adobe rl-adobe commented Apr 16, 2024

Copy link

aem-code-sync bot commented Apr 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 16, 2024

Page Scores Audits
/express/learn/blog/what-is-shopify?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 40.89%. Comparing base (9f33464) to head (0452307).
Report is 39 commits behind head on main.

Files Patch % Lines
...locks/ax-table-of-contents/ax-table-of-contents.js 28.57% 20 Missing ⚠️
express/scripts/utils.js 35.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
- Coverage   56.55%   40.89%   -15.66%     
===========================================
  Files           4        7        +3     
  Lines         801     1225      +424     
===========================================
+ Hits          453      501       +48     
- Misses        348      724      +376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

express/scripts/utils.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/table-of-contents April 18, 2024 12:35 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/table-of-contents April 18, 2024 17:10 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/table-of-contents April 18, 2024 17:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/table-of-contents April 18, 2024 18:38 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/table-of-contents April 23, 2024 02:51 Inactive
const columnBlock = section.querySelectorAll('div.columns');
columnBlock.forEach((column) => {
if (column.classList[0] !== 'columns') return;
column.classList.remove('columns');
column.className = `ax-columns ${column.className}`;
});
};

const repalceTableOfContentBlock = (section) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaceTableOfContentBlock

@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/table-of-contents April 24, 2024 11:57 Inactive
@vhargrave vhargrave merged commit a63d101 into main Apr 24, 2024
6 checks passed
@vhargrave vhargrave deleted the rl-adobe/table-of-contents branch May 2, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants