Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-143407: template-list block #17

Merged
merged 19 commits into from
Apr 15, 2024
Merged

MWPW-143407: template-list block #17

merged 19 commits into from
Apr 15, 2024

Conversation

rl-adobe
Copy link
Contributor

@rl-adobe rl-adobe commented Apr 8, 2024

Copy link

aem-code-sync bot commented Apr 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 8, 2024

Page Scores Audits Google
/express/learn/blog/how-to-party-flyer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rl-adobe rl-adobe changed the title Rl adobe/template list MWPW-143407: template-list Apr 8, 2024
@rl-adobe rl-adobe changed the title MWPW-143407: template-list MWPW-143407: template-list block Apr 8, 2024
}
const allTemplatesMetadata = await fetchAllTemplatesMetadata();
const redirectUrl = getRedirectUrl(currentTasks, searchInput, format, allTemplatesMetadata);
window.location = redirectUrl;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/template-list April 8, 2024 12:47 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.44%. Comparing base (b43d322) to head (c44ca3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   24.44%   24.44%           
=======================================
  Files           1        1           
  Lines         225      225           
=======================================
  Hits           55       55           
  Misses        170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to rl-adobe/template-list April 12, 2024 11:56 Inactive
Copy link
Collaborator

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one small thing. Can you fix that, and then you can merge

express/scripts/utils/decorate.js Outdated Show resolved Hide resolved
@rl-adobe rl-adobe merged commit 7f5ad97 into main Apr 15, 2024
6 checks passed
@vhargrave vhargrave deleted the rl-adobe/template-list branch June 18, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants